perf: push left filters through ASOF joins - #24801
Draft
Xuanwo wants to merge 4 commits into
Draft
Conversation
This was referenced Aug 30, 2026
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #24801 +/- ##
==========================================
+ Coverage 81.47% 81.48% +0.01%
==========================================
Files 1122 1123 +1
Lines 403629 406555 +2926
Branches 403629 406555 +2926
==========================================
+ Hits 328866 331301 +2435
- Misses 55510 55856 +346
- Partials 19253 19398 +145 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
An ASOF join emits each left row exactly once and does not change left-side
values. A deterministic predicate that references only the left input can
therefore run before matching. Right-only and mixed predicates must remain
above the join because unmatched right fields are NULL-padded, and volatile
predicates must keep their original evaluation point.
Pushing the safe subset reduces the number of rows entering the ASOF join
without changing query results.
GitHub shows the cumulative stack because fork branches cannot be selected as
upstream PR bases. The isolated diff for this layer is:
Xuanwo/datafusion@xuanwo/asof-logical...xuanwo/asof-filter-pushdown
What changes are included in this PR?
Are these changes tested?
cargo fmt --allcargo clippy --all-targets --all-features -- -D warningscargo test --profile ci -p datafusion-optimizer asof_join_ --all-featuresAre there any user-facing changes?
No result semantics or public APIs change. Eligible ASOF joins may execute with
fewer left-side rows after logical optimization.