Skip to content

Prepare SQL runner for native benchmark migration #24806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Omega359 wants to merge 1 commit into
base: main
Choose a base branch
from
+444 −63
Open

Prepare SQL runner for native benchmark migration #24806

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
62 changes: 10 additions & 52 deletions benchmarks/benches/sql.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,11 @@
//! `.benchmark` files. Run them with `benchmarks/bench.sh` or directly with
//! Cargo, for example: `BENCH_NAME=tpch cargo bench --bench sql`.

use clap::Parser;
use criterion::{Criterion, criterion_group, criterion_main};
use datafusion_benchmarks::sql_benchmark_runner::{
BenchmarkFilter, SqlRunConfig, default_criterion_replacements,
default_sql_benchmark_directory, run_criterion_benchmarks_impl,
criterion_harness_config_from_env, default_sql_benchmark_directory,
run_criterion_benchmarks_impl_with_namespace,
};
use datafusion_benchmarks::util::CommonOpt;
use datafusion_common::instant::Instant;

#[cfg(feature = "snmalloc")]
Expand All @@ -40,61 +38,21 @@ static ALLOC: snmalloc_rs::SnMalloc = snmalloc_rs::SnMalloc;
#[global_allocator]
static ALLOC: mimalloc::MiMalloc = mimalloc::MiMalloc;

#[derive(Debug, Parser)]
#[command(ignore_errors = true)]
struct EnvParser {
#[command(flatten)]
options: CommonOpt,

#[arg(
env = "BENCH_PERSIST_RESULTS",
long = "persist_results",
default_value = "false",
action = clap::ArgAction::SetTrue
)]
persist_results: bool,

#[arg(
env = "BENCH_VALIDATE",
long = "validate_results",
default_value = "false",
action = clap::ArgAction::SetTrue
)]
validate: bool,

#[arg(env = "BENCH_NAME")]
name: Option<String>,

#[arg(env = "BENCH_SUBGROUP")]
subgroup: Option<String>,

#[arg(env = "BENCH_QUERY")]
query: Option<String>,
}

pub fn sql(c: &mut Criterion) {
env_logger::init();

let start = Instant::now();
let args = EnvParser::parse();
let config = SqlRunConfig {
common: args.options,
filter: BenchmarkFilter {
name: args.name,
subgroup: args.subgroup,
query: args.query,
},
replacements: default_criterion_replacements(),
query_filename: None,
persist_results: args.persist_results,
validate_results: args.validate,
output: None,
};
let (config, criterion_namespace) = criterion_harness_config_from_env();

println!("Loading benchmarks...");

run_criterion_benchmarks_impl(&default_sql_benchmark_directory(), &config, c)
.unwrap_or_else(|err| panic!("failed to run SQL benchmarks: {err:?}"));
run_criterion_benchmarks_impl_with_namespace(
&default_sql_benchmark_directory(),
&config,
criterion_namespace.as_deref(),
c,
)
.unwrap_or_else(|err| panic!("failed to run SQL benchmarks: {err:?}"));

println!(
"Completed benchmarks in {} ms ...",
Expand Down
Loading