fix: preserve fetch across distribution reoptimization - #24809
Open
xudong963 wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #24809 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 1123 1123
Lines 406148 406191 +43
Branches 406148 406191 +43
=======================================
+ Hits 331124 331166 +42
+ Misses 55659 55658 -1
- Partials 19365 19367 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Reoptimizing an already optimized physical plan could silently remove a pushed-down
LIMITstored onSortPreservingMergeExecorCoalescePartitionsExec. This could make a query return more rows than requested.What changes are included in this PR?
fetchwhen a replacement merge operator is inserted.What is the testing strategy for this PR?
Added targeted physical optimizer regression tests covering:
SortPreservingMergeExec;CoalescePartitionsExec;encoded the incorrect removal of its limit.
Validated with:
Are there any user-facing changes?
Queries preserve their requested global limit when physical distribution requirements are optimized more than once. There are no changes to SQL behavior other than fixing the incorrect result, and no changes to documented public APIs.