Skip to content

Doc: note enforce_batch_size_in_joins only applies to symmetric hash join - #24811

Open
2010YOUY01 wants to merge 1 commit into
apache:mainfrom
2010YOUY01:shj-batch-size-doc
Open

Doc: note enforce_batch_size_in_joins only applies to symmetric hash join#24811
2010YOUY01 wants to merge 1 commit into
apache:mainfrom
2010YOUY01:shj-batch-size-doc

Conversation

@2010YOUY01

@2010YOUY01 2010YOUY01 commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Which issue does this PR close?

  • Closes #.

Rationale for this change

This config used to be applicable to most join operators

Now only SHJ is using it, this PR updates the doc. (I think we can eventually deprecate it, but it requires further investigation, so it's left to future work, tracked in #24812)

To verify, search for the config name in the codebase, and only SHJ is using it.

What changes are included in this PR?

What is the testing strategy for this PR?

Are there any user-facing changes?

@github-actions github-actions Bot added documentation Improvements or additions to documentation common Related to common crate labels Aug 31, 2026
@github-actions github-actions Bot added the sqllogictest SQL Logic Tests (.slt) label Aug 31, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.52%. Comparing base (e4cf35c) to head (b477e91).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #24811   +/-   ##
=======================================
  Coverage   81.52%   81.52%           
=======================================
  Files        1123     1123           
  Lines      406148   406230   +82     
  Branches   406148   406230   +82     
=======================================
+ Hits       331124   331191   +67     
- Misses      55659    55666    +7     
- Partials    19365    19373    +8     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to common crate documentation Improvements or additions to documentation sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants