Doc: note enforce_batch_size_in_joins only applies to symmetric hash join - #24811
Open
2010YOUY01 wants to merge 1 commit into
Open
Doc: note enforce_batch_size_in_joins only applies to symmetric hash join#248112010YOUY01 wants to merge 1 commit into
enforce_batch_size_in_joins only applies to symmetric hash join#248112010YOUY01 wants to merge 1 commit into
Conversation
2010YOUY01
force-pushed
the
shj-batch-size-doc
branch
from
August 31, 2026 06:32
46ac0d9 to
b477e91
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24811 +/- ##
=======================================
Coverage 81.52% 81.52%
=======================================
Files 1123 1123
Lines 406148 406230 +82
Branches 406148 406230 +82
=======================================
+ Hits 331124 331191 +67
- Misses 55659 55666 +7
- Partials 19365 19373 +8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
saadtajwar
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
This config used to be applicable to most join operators
Now only SHJ is using it, this PR updates the doc. (I think we can eventually deprecate it, but it requires further investigation, so it's left to future work, tracked in #24812)
To verify, search for the config name in the codebase, and only SHJ is using it.
What changes are included in this PR?
What is the testing strategy for this PR?
Are there any user-facing changes?