refactor(proto): destructure FileScanConfig and MemorySourceConfig serde hooks - #24813
Open
buraksenn wants to merge 1 commit into
Open
refactor(proto): destructure FileScanConfig and MemorySourceConfig serde hooks#24813buraksenn wants to merge 1 commit into
buraksenn wants to merge 1 commit into
Conversation
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #24813 +/- ##
==========================================
- Coverage 81.52% 81.52% -0.01%
==========================================
Files 1123 1123
Lines 405970 406349 +379
Branches 405970 406349 +379
==========================================
+ Hits 330983 331277 +294
- Misses 55626 55689 +63
- Partials 19361 19383 +22 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Proto hooks that access fields individually can silently omit newly added state. Exhaustive destructuring makes such omissions compile errors.
FileScanConfigis shared by all file sources, so a field omitted here is lost for Parquet, CSV, JSON, Arrow, and Avro.What changes are included in this PR?
FileScanConfigandMemorySourceConfigin their encoders.preserve_orderfield so explicit values survive file scan round trips while older payloads retain their ordering-derived behavior.MemorySourceConfigsort information against the projected schema without applying projection twice.The protobuf change is additive and backward compatible.
Are these changes tested?
Added or updated coverage for:
preserve_ordervalues and legacy payload behaviorAre there any user-facing changes?
File scans now preserve an explicit
preserve_ordervalue across protobuf round trips. Default serialization of plans containing custom expression adapter factories now returns an explicit error rather than silently dropping the factory.Projected memory sources now preserve their sort information across round trips. The new protobuf field is additive, and
PhysicalExprAdapterFactorygains a default method, so existing implementations remain source compatible.