fix: aggregate dynamic filtering with unsupported expressions - #24817
Open
lyne7-sc wants to merge 2 commits into
Open
fix: aggregate dynamic filtering with unsupported expressions#24817lyne7-sc wants to merge 2 commits into
lyne7-sc wants to merge 2 commits into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #24817 +/- ##
========================================
Coverage 81.53% 81.53%
========================================
Files 1123 1123
Lines 406042 406284 +242
Branches 406042 406284 +242
========================================
+ Hits 331059 331257 +198
- Misses 55621 55660 +39
- Partials 19362 19367 +5 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Aggregate dynamic filtering currently ignores unsupported expressions while still generating a shared scan predicate from supported aggregates. This can prune rows required by the unsupported aggregate and produce incorrect results.
What changes are included in this PR?
What is the testing strategy for this PR?
Yes. Updated the existing sqllogictest case in
push_down_filter_regression.slt.Are there any user-facing changes?
Yes. This fixes potentially incorrect query results. No API changes.