Repository navigation
fix: retain only valid orderings after order-preserving repartition - #26747
Open
Kristofferjoha wants to merge 2 commits into
Open
Kristofferjoha wants to merge 2 commits into
Kristofferjoha wants to merge 2 commits into
Conversation
Contributor
Author
|
@jayzhan211 This should be ready for review. It needed a little more than following #26654, as keeping only the merge key ordering also removed valid cast-derived orderings, causing an existing unbounded-stream query to fail planning. This PR also preserves projected cast relationships so those valid orderings can be inferred again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #26745.
Rationale for this change
An order-preserving repartition can incorrectly retain independent input orderings that do not hold after merging partitions. This lets the planner remove a necessary sort, causing
ORDER BYto return rows in the wrong order.What changes are included in this PR?
What is the testing strategy for this PR?
order.slt, verifying exact row order.equivalence_properties.sltandmonotonic_projection_test.slt.Are there any user-facing changes?
Only that queries affected by #26745 now return rows in the requested order.