[Fix-18672][UI] Allow SeaTunnel workflow tasks to select stream execution by sunlishuo25 · Pull Request #18673 · apache/dolphinscheduler

sunlishuo25 · 2026-10-03T01:40:59Z

Was this PR generated or assisted by AI?

YES. I found this issue myself. I used AI as an assistant to help write the code changes, and I manually reviewed and verified all of them.

Purpose of the pull request

Fixes #18672.

A SeaTunnel task in a workflow is always saved as taskExecuteType=BATCH, and the form gives no way to choose Stream, so a streaming SeaTunnel job can never appear under Task Instance -> Stream Task. This PR adds an explicit Batch/Stream choice to the SeaTunnel form. Batch stays the default, including for existing definitions.

The backend already persists taskExecuteType and copies it to task instances, so no backend change is needed.

Brief change log

SeaTunnel form: add a Batch/Stream radio bound to the existing taskExecuteType field.
useTask: keep the saved taskExecuteType when an existing task is reopened.
Task modal (detail-modal.tsx): clear the saved taskExecuteType when the task type changes, so the new task type starts from its own default.
DAG: carry each task's execution type through loading, copying and editing, and update the dashed edge style when it changes.
editTask now edits a copy of the task definition, so changes made in the modal (e.g. task type) are discarded on Cancel instead of leaking into the definition.
Stream task instance list: disable the savepoint action for SeaTunnel, which does not implement StreamTask. Flink savepoint is unchanged.
E2E: add SeaTunnelTaskE2ETest (under cases/tasks, following the existing page object structure) with real SeaTunnel and Flink fixtures, and register it in the E2E matrix. Shared page objects that no longer matched the current UI are fixed, and the DAG format button gets the graph-format class that WorkflowForm already uses to locate it.
Docs: describe the option in the English and Chinese SeaTunnel task docs.

Verify this pull request

SeaTunnelTaskE2ETest covers, in six focused scenarios:

Batch default, Cancel/Save, and persistence after reopening the workflow.
Copying a STREAM task keeps STREAM.
Edge style switches between solid and dashed with BATCH/STREAM.
A real BATCH run succeeds and is listed only under Batch Task.
A real STREAM run is listed only under Stream Task, its savepoint action is disabled, and it can be stopped from the UI.
A real local-mode FLINK_STREAM SQL job is listed under Stream Task and keeps its savepoint action enabled.

The official workflows passed on my fork (ubuntu-latest, AMD64): E2E for 64e5cac (all 24 jobs; SeaTunnelTaskE2ETest ran 6 tests with 0 failures in about 10 minutes, well within the 30-minute limit), and Backend, Frontend, Test, API-Test, E2E-K8S and CodeQL for 7713eb1. The commits after 7713eb1 only change E2E test code.

Pull Request Notice

…tion

boring-cyborg · 2026-10-03T01:41:03Z

Thanks for opening this pull request! Please check out our contributing guidelines. (https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/contribute/join/pull-request.md)

Discard the previous task's stored execution mode only when its task type changes, so the new type uses the existing defaults. Preserve SeaTunnel's explicit mode when the type is unchanged and when a definition is reopened. Add focused source checks for task type transitions, mode preservation, custom/resource configuration round trips, and legacy defaults.

SbloodyS

The new E2E covers execution-type selection and save/reload, but leaves several changed paths untested.

Please add regression coverage for copying a STREAM SeaTunnel task, updating connected-edge styling when switching between BATCH and STREAM, and disabling SeaTunnel savepoint while keeping Flink savepoint enabled.

The test also never executes the workflow or checks the Stream Task instance list, so it does not verify the instance-classification outcome described in the PR.

Keep a task query pending while its table is visibly loading instead of repeatedly refreshing it. Read the task state before sampling the current table class, avoiding a loading-selector lookup that could wait for the next poll. Preserve prompt business assertions and the existing120-second/500ms wait.

Locate this case's exact task operation cell under the existing Batch and Stream row boundaries. Preserve the original native retry and ten-second completion wait, and check the visible Log completion after each successful click in the same iteration. Keep shared page helpers, Stop, workflow assertions and engine waits unchanged.

SbloodyS

WorkflowSeaTunnelE2ETest failed. Please fix it. @sunlishuo25

Give the SeaTunnel case a 90-minute budget while retaining 30 minutes for other cases. Bound both pinned fixture downloads and confirm project creation with native Enter, preserving the existing business assertions.

sunlishuo25 · 2026-10-13T17:08:08Z

@SbloodyS I ran the full WorkflowSeaTunnelE2ETest locally, and it passed on Linux ARM64 with the default application and SeaTunnel heap settings: 1 test, 0 failures, 0 errors, 0 skipped. I've attached the test report, relevant logs, and recording.

DolphinScheduler-18673-complete-evidence.zip

SbloodyS · 2026-10-14T03:57:02Z

    needs: build
    runs-on: ubuntu-latest
-    timeout-minutes: 30
+    timeout-minutes: ${{ matrix.case.name == 'WorkflowSeaTunnelE2ETest' && 90 || 30 }}


All e2e tests need to be completed within 30 minutes. Please optimize the implementation.

sunlishuo25 · 2026-10-14T18:30:11Z

@SbloodyS I've restored the 30-minute timeout and fixed the E2E UI interactions. Both WorkflowSwitchE2ETest and WorkflowSeaTunnelE2ETest passed locally on Linux ARM64 with the default application and SeaTunnel heap settings. The test reports, logs, and recordings are attached in one ZIP.

pr-18673-local-e2e-evidence.zip

SbloodyS · 2026-10-16T03:35:47Z

 public final class SwitchTaskForm extends TaskNodeForm {

-    @FindBy(id = "btnAddIfBranch")
+    static final String NODE_MODAL = "//div[contains(concat(' ', normalize-space(@class), ' '), ' n-modal ')"


Please don't modify irrelevant code in all places.

Removed the unrelated changes and pushed the update. The local SeaTunnel E2E test passed; CI is awaiting approval.

- Remove dolphinscheduler-ui/tests/*.cjs, which no workflow runs. - Replace the JavaScript scrollIntoView in SeaTunnelTaskForm with native WebDriver wheel actions. - Run the BATCH job before the STREAM job and drop the extra shell workflows that tracked engine PIDs. - Assert that the savepoint action is disabled for the SeaTunnel stream instance.

sunlishuo25 · 2026-10-16T09:28:38Z

@SbloodyS I've cleaned up the PR in 850ce3e:

Removed the unused dolphinscheduler-ui/tests/*.cjs scripts.
Replaced the JavaScript scrollIntoView in SeaTunnelTaskForm with native WebDriver actions.
Simplified WorkflowSeaTunnelE2ETest: the BATCH job now runs before the STREAM job, so the extra shell workflows that tracked engine PIDs are gone. It also asserts that the savepoint action is disabled for SeaTunnel.

The same commit passed the official E2E workflow on my fork: WorkflowSeaTunnelE2ETest (1 test, 0 failures, ~7 min on AMD64), and all 24 E2E jobs were green.

Run a real local-mode FLINK_STREAM SQL job in WorkflowSeaTunnelE2ETest and assert that its savepoint action stays enabled in the Stream task instance list, alongside the disabled SeaTunnel savepoint. The fixture now installs Flink 1.20.3.

# Conflicts: # dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/pages/project/workflow/WorkflowForm.java

Wait for the shared data-modal-ready marker instead of Naive UI transition classes, click modal controls through UiInteraction, and enter the SeaTunnel script through CodeEditor. The Flink SQL form keeps keyboard input because its initialization script editor is visible alongside the script editor.

SbloodyS

Please resolves conflicts.

sunlishuo25 · 2026-10-17T03:54:43Z

@SbloodyS I've resolved the conflicts by merging the latest dev, keeping the waits added in #18715 and only passing this test's drop coordinates through addTask. The SeaTunnel E2E now follows the helpers from #18715: it waits for data-modal-ready, clicks modal controls through UiInteraction, and enters the SeaTunnel script through CodeEditor.

This update also covers your earlier request to keep Flink savepoint enabled. WorkflowSeaTunnelE2ETest now runs a real local-mode FLINK_STREAM SQL job (datagen to print) on Flink 1.20.3, checks real print-sink rows in the task log, and asserts that its savepoint action stays enabled while SeaTunnel's is disabled.

On my fork, the E2E workflow for this commit passed: all 24 jobs after re-running one unrelated job whose Docker Compose environment failed to start. Backend, Frontend, Test, API-Test, E2E-K8S and CodeQL passed as well.

SbloodyS

Please refactor this E2E test to follow the project's existing Page Object Model and test structure.

Reuse the existing Page Objects for project navigation, task configuration, submission, and workflow execution. If an existing interaction needs improvement, fix it in the corresponding Page Object instead of adding a separate implementation inside WorkflowSeaTunnelE2ETest.

Please also consolidate overlapping node lookup/opening logic, reduce unnecessary helper methods, and keep changes to shared helpers such as addTask and dragAndDrop.js limited to demonstrated needs. Split the long test into focused scenarios with explicit setup dependencies, while preserving the real SeaTunnel/Flink execution and regression assertions.

SbloodyS · 2026-10-17T05:57:25Z

+
+    @SneakyThrows
+    @SuppressWarnings("unchecked")
+    public <T> T addTask(TaskType type, Integer x, Integer y) {


Remove unnessnary changes.

Removed the overload and restored dragAndDrop.js to dev. The test now lays out the dropped nodes with the existing formatDAG() instead of passing drop coordinates; I fixed formatDAG() / WorkflowFormatDialog because they no longer matched the current UI (details in my review reply).

- Move the test to cases/tasks/SeaTunnelTaskE2ETest, extend BaseWorkflowE2ETest and split it into focused scenarios that keep the real SeaTunnel and Flink runs and all regression assertions. - Remove the addTask coordinate overload and restore dragAndDrop.js; lay out nodes with formatDAG instead. - Fix the existing page objects instead of adding test-local helpers: preTask, the DAG format dialog, exact task lookup in getTask, CodeEditor reading, workflow editing and task instance logs. - Add the graph-format class that WorkflowForm already uses to locate the DAG format button.

…loading the page

sunlishuo25 · 2026-10-17T13:11:35Z

@SbloodyS Thanks for the review. I've refactored the test to use the existing page objects: it is now cases/tasks/SeaTunnelTaskE2ETest, extends BaseWorkflowE2ETest, and is split into six @Order scenarios that only depend on @BeforeAll (except that the STREAM scenario reuses the BATCH run as evidence that the Batch list has loaded). The real SeaTunnel/Flink runs and all regression assertions are kept. The addTask(type, x, y) overload and the dragAndDrop.js change are removed. All 24 E2E jobs pass on my fork: run.

Where the existing page objects failed, and the fix:

WorkflowSaveDialog.submit(): failed in testCopiedStreamTaskKeepsExecutionType when saving an existing workflow, with ElementClickInterceptedException on the submit button, because it clicks while the dialog is still opening (job). It now clicks through UiInteraction, as in [Improvement-18712][E2E] Fix flaky e2e test #18715.
WorkflowForm.getTask(): failed in testEdgeStyleFollowsExecutionType. After formatDAG(), the node was outside the scrolled canvas, so the double-click missed it and the task modal never opened (job). It now scrolls the node into view first, and matches the exact title so a copied task is not mistaken for its source.
WorkflowForm.formatDAG(), WorkflowFormatDialog.confirm() and TaskNodeForm.preTask(): these look for graph-format, el-dialog__wrapper / el-button--primary and option-pre-tasks, none of which exist in the current UI, so they cannot work. Their only user, WorkflowSwitchE2ETest, is disabled. I added graph-format to the format button (the only production change, the same way as btn-save) and moved the dialog and preTask to UiInteraction.

The other page object additions are new methods the scenarios need.

CI runs on my fork:

Failed with the existing page objects: WorkflowSaveDialog.submit(), WorkflowForm.getTask()
Passed after the fixes: all 24 E2E jobs

[Fix-18672][UI] Allow SeaTunnel workflow tasks to select stream execu…

f72c7aa

…tion

github-actions Bot added UI ui and front end related test e2e e2e test document labels Oct 3, 2026

github-actions Bot assigned sunlishuo25 Oct 3, 2026

[Fix-18672][CI] Register SeaTunnel workflow regression test

c46368c

github-actions Bot added the CI&CD label Oct 3, 2026

sunlishuo25 marked this pull request as ready for review October 3, 2026 02:31

sunlishuo25 requested a review from SbloodyS as a code owner October 3, 2026 02:31

sunlishuo25 and others added 5 commits October 3, 2026 14:06

[Fix-18672][E2E] Scroll SeaTunnel execution type into view

e2675d4

Merge branch 'dev' into Fix-18672

487ee30

fix(ui): isolate task editor changes until confirmation

1c879a4

Merge branch 'dev' into Fix-18672

eed7221

SbloodyS added the first time contributor First-time contributor label Oct 5, 2026

sunlishuo25 and others added 3 commits October 5, 2026 22:01

Merge local task editor repairs onto maintainer update

85f1397

fix(ui): retain task type graph default on confirmation

81c5273

Merge branch 'dev' into Fix-18672

d1cb01f

SbloodyS added this to the 3.5.0 milestone Oct 6, 2026

SbloodyS added the bug Something isn't working label Oct 6, 2026

Merge validated task editor repairs with latest maintainer changes

74650d7

SbloodyS requested changes Oct 6, 2026

View reviewed changes

sunlishuo25 added 6 commits October 6, 2026 16:43

test: cover SeaTunnel copy graph mode and instance classification

4ee3eef

[Fix-18672][E2E] Center task bodies before canvas pointer actions

5681f5a

[Fix-18672][E2E] Verify task identity before native pointer actions

434b40a

[Fix-18672][E2E] Retry instance reads after table refresh

565555f

[Fix-18672][E2E] Wait for save modal transitions before clicking

201bb6c

[Fix-18672][E2E] Wait for task modal readiness before editing

f1acc46

sunlishuo25 and others added 6 commits October 12, 2026 20:11

[Fix-18673][E2E] Wait for reopened SeaTunnel workflow readiness

b01f4f3

[Fix-18673][E2E] Wait for editor before existing graph data checks

34e19ca

[Fix-18673][E2E] Reuse timeout scope for workflow navigation

88c15df

Merge branch 'dev' into Fix-18672

8cbdf6e

SbloodyS reviewed Oct 13, 2026

View reviewed changes

Stabilize SeaTunnel E2E setup and allow slow fixture downloads

20b576b

Give the SeaTunnel case a 90-minute budget while retaining 30 minutes for other cases. Bound both pinned fixture downloads and confirm project creation with native Enter, preserving the existing business assertions.

Merge branch 'dev' into Fix-18672

3712aa2

SbloodyS requested changes Oct 14, 2026

View reviewed changes

fix(e2e): stabilize workflow helpers and enforce 30-minute jobs

19dd101

Merge branch 'dev' into Fix-18672

239dab7

SbloodyS requested changes Oct 16, 2026

View reviewed changes

sunlishuo added 2 commits October 16, 2026 15:03

test(e2e): keep SeaTunnel interactions scoped to its coverage

10233f7

sunlishuo added 3 commits October 16, 2026 18:31

Merge remote-tracking branch 'upstream/dev' into Fix-18672

0fa0b9d

# Conflicts: # dolphinscheduler-e2e/dolphinscheduler-e2e-case/src/test/java/org/apache/dolphinscheduler/e2e/pages/project/workflow/WorkflowForm.java

SbloodyS reviewed Oct 16, 2026

View reviewed changes

Merge branch 'dev' into Fix-18672

7745d44

SbloodyS reviewed Oct 17, 2026

View reviewed changes

sunlishuo added 4 commits October 17, 2026 18:55

[Fix-18672][E2E] Wait for the workflow save dialog before submitting it

6ac8aa1

[Fix-18672][E2E] Scroll DAG tasks into view before clicking them

9ed1feb

[Fix-18672][E2E] Poll the self-refreshing Stream task list without re…

64e5cac

…loading the page

Conversation

sunlishuo25 commented Oct 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Was this PR generated or assisted by AI?

Purpose of the pull request

Brief change log

Verify this pull request

Pull Request Notice

Uh oh!

boring-cyborg Bot commented Oct 3, 2026

Uh oh!

SbloodyS left a comment

Choose a reason for hiding this comment

Uh oh!

SbloodyS left a comment

Choose a reason for hiding this comment

Uh oh!

sunlishuo25 commented Oct 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SbloodyS Oct 14, 2026

Choose a reason for hiding this comment

Uh oh!

sunlishuo25 commented Oct 14, 2026

Uh oh!

SbloodyS Oct 16, 2026

Choose a reason for hiding this comment

Uh oh!

sunlishuo25 Oct 16, 2026

Choose a reason for hiding this comment

Uh oh!

sunlishuo25 commented Oct 16, 2026

Uh oh!

SbloodyS left a comment

Choose a reason for hiding this comment

Uh oh!

sunlishuo25 commented Oct 17, 2026

Uh oh!

SbloodyS left a comment

Choose a reason for hiding this comment

Uh oh!

SbloodyS Oct 17, 2026

Choose a reason for hiding this comment

Uh oh!

sunlishuo25 Oct 17, 2026

Choose a reason for hiding this comment

Uh oh!

sunlishuo25 commented Oct 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

sunlishuo25 commented Oct 3, 2026 •

edited

Loading

sunlishuo25 commented Oct 13, 2026 •

edited

Loading

sunlishuo25 commented Oct 17, 2026 •

edited

Loading