Skip to content

feat: User-aware SchemaProviders for SQL. - #20075

Open
gianm wants to merge 3 commits into
apache:masterfrom
gianm:schema-providers
Open

feat: User-aware SchemaProviders for SQL.#20075
gianm wants to merge 3 commits into
apache:masterfrom
gianm:schema-providers

Conversation

@gianm

@gianm gianm commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

This patch adds a SchemaProvider interface, which can provide schemas based on the identity of the current user. SqlBindings#addSchemaProvider can be used by extension to add such providers.

In core, this patch moves the "druid", "view", and "sys" schemas to use schema providers that filter out unauthorized tables and views. This improves the behavior for unauthorized tables. Previously unauthorized tables were explicitly filtered out of InformationSchema, so users could not see them in metadata queries. However, they were visible to the validator, so a query that explicitly named such a table would return a "Forbidden" error. Now the error is "table not found".

To preserve the functioning of view expansion, views are now expanded using an escalated schema. Comments about the view security model are added to ViewManager's javadoc.

To ensure that table validation happens as expected at ingestion time, INSERT and REPLACE now require READ access (in addition to WRITE) on the target table.

A new configuration option "druid.sql.planner.authorizeTableVisibility" (default true) is added. If set explicitly to false, the old behavior is restored.

This patch adds a SchemaProvider interface, which can provide schemas
based on the identity of the current user. SqlBindings#addSchemaProvider
can be used by extension to add such providers.

In core, this patch moves the "druid", "view", and "sys" schemas to use
schema providers that filter out unauthorized tables and views. This
improves the behavior for unauthorized tables. Previously unauthorized
tables were explicitly filtered out of InformationSchema, so users could
not see them in metadata queries. However, they were visible to the
validator, so a query that explicitly named such a table would return
a "Forbidden" error. Now the error is "table not found".

To preserve the functioning of view expansion, views are now expanded
using an escalated schema. Comments about the view security model
are added to ViewManager's javadoc.

To ensure that table validation happens as expected at ingestion time,
INSERT and REPLACE now require READ access (in addition to WRITE) on
the target table.

A new configuration option "druid.sql.planner.authorizeTableVisibility"
(default true) is added. If set explicitly to false, the old behavior
is restored.
@github-actions github-actions Bot added Area - Documentation Area - Batch Ingestion Area - Querying Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 labels Aug 19, 2026
@gianm

gianm commented Aug 19, 2026

Copy link
Copy Markdown
Contributor Author

Suggested release note:

READ permissions are now required for tables to be visible to the SQL validator. This means that queries against tables where the user lacks READ permission now result in "not found" rather than "forbidden" errors. Additionally, INSERT or REPLACE into a table now requires both READ and WRITE permissions (rather than only WRITE). To restore the old behavior, set druid.sql.planner.authorizeTableVisibility = false.

@gianm gianm closed this Aug 19, 2026
@gianm gianm reopened this Aug 19, 2026

@FrankChen021 FrankChen021 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.

Reviewed 82 of 82 changed files.


This is an automated review by Codex GPT-5.6-Luna(max)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area - Batch Ingestion Area - Documentation Area - MSQ For multi stage queries - https://github.com/apache/druid/issues/12262 Area - Querying Release Notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants