fix: handle byte[] complex types from realtime segments in MSQ scans (#18340) - #20091
Open
zhang-arvin wants to merge 1 commit into
Open
fix: handle byte[] complex types from realtime segments in MSQ scans (#18340)#20091zhang-arvin wants to merge 1 commit into
zhang-arvin wants to merge 1 commit into
Conversation
FrankChen021
left a comment
Member
There was a problem hiding this comment.
I have reviewed the code for correctness, edge cases, concurrency, and integration risks; no issues found.
Reviewed 2 of 2 changed files.
This is an automated review by Codex GPT-5.6-Luna(max)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When MSQ scans realtime segments containing complex types,
ColumnValueSelector.getObject()returns the already-serializedbyte[]form rather than the deserialized object.ComplexMetricSerde.toBytes()callsObjectStrategy.toBytes(val)which expects the deserialized object typeT, causing aClassCastExceptionwhen the value is actuallybyte[].This fix adds a new
objectToBytes(Object val)default method toObjectStrategythat checks if the value is already abyte[]and returns it directly, otherwise delegates to the existingtoBytes(T val)method.ComplexMetricSerde.toBytes()is updated to useobjectToBytes()instead oftoBytes().Changes
objectToBytes(Object val)default method that handlesbyte[]input directlytoBytes(val)toobjectToBytes(val)in the serdeFixes #18340.