Skip to content

test(processing): avoid JDK crash in schemaless segment test #20121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FrankChen021 wants to merge 3 commits into
base: master
Choose a base branch
from
+221 −201
Open

test(processing): avoid JDK crash in schemaless segment test #20121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5285b76
test(processing): isolate schemaless test segments
FrankChen021 Aug 22, 2026
7b7e147
test(processing): close schemaless segments per test
FrankChen021 Aug 22, 2026
50c17d3
test(processing): use secure temporary directories
FrankChen021 Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
96 changes: 56 additions & 40 deletions processing/src/test/java/org/apache/druid/segment/SchemalessIndexTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,11 @@ public static IncrementalIndex getIncrementalIndex()
}
}

IncrementalIndex createIncrementalIndex()
{
return makeIncrementalIndex(TEST_FILE, METRIC_AGGS);
}

public static QueryableIndex getIncrementalIndex(int index1, int index2)
{
synchronized (log) {
Expand Down Expand Up @@ -178,45 +183,61 @@ public QueryableIndex getMergedIncrementalIndex()
return mergedIndex;
}

try {
IncrementalIndex top = makeIncrementalIndex("druid.sample.json.top", METRIC_AGGS);
IncrementalIndex bottom = makeIncrementalIndex("druid.sample.json.bottom", METRIC_AGGS);
mergedIndex = createMergedIncrementalIndex();
return mergedIndex;
}
}

File tmpFile = File.createTempFile("yay", "who");
tmpFile.delete();
QueryableIndex createMergedIncrementalIndex()
{
final IncrementalIndex top = makeIncrementalIndex("druid.sample.json.top", METRIC_AGGS);
final IncrementalIndex bottom = makeIncrementalIndex("druid.sample.json.bottom", METRIC_AGGS);
QueryableIndex topIndex = null;
QueryableIndex bottomIndex = null;

File topFile = new File(tmpFile, "top");
File bottomFile = new File(tmpFile, "bottom");
File mergedFile = new File(tmpFile, "merged");
try {
File tmpFile = FileUtils.createTempDir("yay");

FileUtils.mkdirp(topFile);
FileUtils.mkdirp(bottomFile);
FileUtils.mkdirp(mergedFile);
topFile.deleteOnExit();
bottomFile.deleteOnExit();
mergedFile.deleteOnExit();
File topFile = new File(tmpFile, "top");
File bottomFile = new File(tmpFile, "bottom");
File mergedFile = new File(tmpFile, "merged");

indexMerger.persist(top, topFile, INDEX_SPEC, null);
indexMerger.persist(bottom, bottomFile, INDEX_SPEC, null);
FileUtils.mkdirp(topFile);
FileUtils.mkdirp(bottomFile);
FileUtils.mkdirp(mergedFile);
topFile.deleteOnExit();
bottomFile.deleteOnExit();
mergedFile.deleteOnExit();

mergedIndex = indexIO.loadIndex(
indexMerger.mergeQueryableIndex(
Arrays.asList(indexIO.loadIndex(topFile), indexIO.loadIndex(bottomFile)),
true,
METRIC_AGGS,
mergedFile,
INDEX_SPEC,
null,
-1
)
);
indexMerger.persist(top, topFile, INDEX_SPEC, null);
indexMerger.persist(bottom, bottomFile, INDEX_SPEC, null);
topIndex = indexIO.loadIndex(topFile);
bottomIndex = indexIO.loadIndex(bottomFile);

return mergedIndex;
return indexIO.loadIndex(
indexMerger.mergeQueryableIndex(
Arrays.asList(topIndex, bottomIndex),
true,
METRIC_AGGS,
mergedFile,
INDEX_SPEC,
null,
-1
)
);
}
catch (IOException e) {
throw new RuntimeException(e);
}
finally {
if (topIndex != null) {
topIndex.close();
}
catch (IOException e) {
mergedIndex = null;
throw new RuntimeException(e);
if (bottomIndex != null) {
bottomIndex.close();
}
top.close();
bottom.close();
}
}

Expand All @@ -239,8 +260,7 @@ public QueryableIndex getMergedIncrementalIndex(int index1, int index2)
}

try {
File tmpFile = File.createTempFile("yay", "who");
tmpFile.delete();
File tmpFile = FileUtils.createTempDir("yay");

File mergedFile = new File(tmpFile, "merged");

Expand Down Expand Up @@ -277,8 +297,7 @@ public QueryableIndex getMergedIncrementalIndex(int[] indexes)
}

try {
File tmpFile = File.createTempFile("yay", "who");
tmpFile.delete();
File tmpFile = FileUtils.createTempDir("yay");

File mergedFile = new File(tmpFile, "merged");

Expand Down Expand Up @@ -364,9 +383,7 @@ private void makeRowPersistedIndexes()
new MapBasedInputRow(timestamp, dims, event)
);

File tmpFile = File.createTempFile("billy", "yay");
tmpFile.delete();
FileUtils.mkdirp(tmpFile);
File tmpFile = FileUtils.createTempDir("billy");
tmpFile.deleteOnExit();

indexMerger.persist(rowIndex, tmpFile, INDEX_SPEC, null);
Expand Down Expand Up @@ -444,8 +461,7 @@ private List<File> makeFilesToMap(File tmpFile, Iterable<Pair<String, Aggregator
private QueryableIndex makeMergedMMappedIndex(Iterable<Pair<String, AggregatorFactory[]>> files)
{
try {
File tmpFile = File.createTempFile("yay", "who");
tmpFile.delete();
File tmpFile = FileUtils.createTempDir("yay");
File mergedFile = new File(tmpFile, "merged");
FileUtils.mkdirp(mergedFile);
mergedFile.deleteOnExit();
Expand Down
Loading
Loading