minor: Emit taskType on task count metrics from the statsd and prometheus emitters - #20123
Open
amaechler wants to merge 1 commit into
Open
minor: Emit taskType on task count metrics from the statsd and prometheus emitters#20123amaechler wants to merge 1 commit into
taskType on task count metrics from the statsd and prometheus emitters#20123amaechler wants to merge 1 commit into
Conversation
…itters The overlord's TaskQueue has tagged every task count RowKey with taskType since apache#18032, and docs/operations/metrics.md documents taskType on all five task/*/count metrics. Both emitters filter user dimensions through a per-metric allow-list, and neither list included taskType, so the dimension was dropped on the way out. task/run/time is already allow-listed on ["dataSource", "taskType"] in both files. Without it a task failure ratio cannot distinguish compaction retry churn from real streaming ingestion failures: one failing MSQ auto-compaction job emits one controller plus one row per worker, which is enough to pin a failure-ratio alert with no way to filter it out. supervisorId is documented on these metrics too but is left out here. It is set only for SeekableStreamIndexTask, and TaskCountStatsMonitor.emit reuses a single ServiceMetricEvent.Builder across map entries, so a conditional dimension leaks from one event into later ones. That needs fixing first.
amaechler
changed the title
taskType on task count metrics from the statsd and prometheus emitterstaskType on task count metrics from the statsd and prometheus emitters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
taskTypeto the various task count metrics, so they can easily be filtered by type.I came across this when trying to filter
task/error/countby type. docs/operations/metrics.md already documentstaskTypeon all five task/*/count metrics.This PR has: