Repository navigation
YARN-11995. Preserve custom resource allocations in timeline container history (branch-3.4) - #8810
Open
gerashegalov wants to merge 2 commits into
Open
gerashegalov wants to merge 2 commits into
gerashegalov wants to merge 2 commits into
Conversation
…r history (apache#8770) Contributed by Gera Shegalov * YARN-11995. Preserve custom resource allocations in timeline container history. Persist nonzero custom resource allocations and their units in YARN_CONTAINER_ALLOCATED_RESOURCES. Update all three timeline publishers and both history report converters, preserving compatibility with existing memory/vcore fields and legacy entities. Snapshot allocations before asynchronous publication. Convert stored values to the reader's configured units, skip unknown or malformed entries individually, and omit the field when no custom allocation exists. Add regression tests and document the stored format, resource-type configuration requirements, and limitations for older history data. Contains content generated by OpenAI Codex. Reviewed-by: Jose Luis López López <joseluisll@gmail.com> Reviewed-by: Shilun Fan <slfan1989@apache.org> Signed-off-by: Gera Shegalov <gshegalov@nvidia.com> (cherry picked from commit 7d8dc18)
Contributor
Author
|
@joseluisll PTAL |
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
The Yetus The separate |
Contributor
The new test never closes its ClientResponse. The already existing tests don't either, so I'd leave it. |
slfan1989
approved these changes
Oct 12, 2026
slfan1989
left a comment
slfan1989
left a comment
Contributor
There was a problem hiding this comment.
The backport looks good to me.
The remaining CI issues appear unrelated to this patch.
One small, non-blocking suggestion: please close the new ClientResponse in a finally block, including the FORBIDDEN path, to preserve the cleanup provided by the original test.
Contains content generated by OpenAI Codex. Signed-off-by: Gera Shegalov <gshegalov@nvidia.com>
|
💔 -1 overall
This message was automatically generated. |
Contributor
Author
|
@joseluisll PTAL |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of PR
Backport YARN-11995 from #8770 to
branch-3.4by cherry-picking trunk commit7d8dc187523c38d2df607fa251693fc11bb6de0dwith-x.The production changes are unchanged. The test changes adapt the backport to the branch's JUnit 4 test classes and Jersey 1 AHS web-test API. This preserves custom container resource allocations and units across the YARN timeline publishers and history readers while retaining compatibility with existing memory/vcore fields and older timeline entities. A follow-up closes the new AHS test's
ClientResponseon both success andFORBIDDENpaths.Contains content generated by OpenAI Codex.
How was this patch tested?
TestTimelineServiceHelper,TestApplicationHistoryManagerOnTimelineStore,TestAHSWebServices,TestSystemMetricsPublisher,TestSystemMetricsPublisherForV2,TestNMTimelinePublisher, andTestAHSv2ClientImpl: 113 tests passed, no failures or errors.TestAHSWebServices: 38 tests passed, no failures or errors.git diff --checkpassed.For code changes:
LICENSE,LICENSE-binary,NOTICE-binaryfiles? (Not applicable.)