Skip to content

Fix hop-conf variable option handling - #7856

Draft
gvdutra wants to merge 1 commit into
apache:mainfrom
gvdutra:5979-fix-hop-conf-variables
Draft

Fix hop-conf variable option handling#7856
gvdutra wants to merge 1 commit into
apache:mainfrom
gvdutra:5979-fix-hop-conf-variables

Conversation

@gvdutra

@gvdutra gvdutra commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

Summary

  • report variable value and description updates as handled hop-conf actions
  • add regression coverage for -sv and -dv

Root cause

The variable options updated the configuration but returned false from their handler. hop-conf therefore treated a successful update as if no action had been requested and displayed usage information.

Validation

  • ./mvnw -pl engine -am -Dtest=SetHopConfigVariablesTest -Dsurefire.failIfNoSpecifiedTests=false test
  • ./mvnw -pl engine -DskipTests spotless:check
  • git diff --check

Closes #5979

@gvdutra
gvdutra marked this pull request as ready for review August 9, 2026 00:29
@hansva hansva added this to the 2.19 milestone Aug 10, 2026
@hansva
hansva marked this pull request as draft August 10, 2026 12:36
@hansva hansva modified the milestones: 2.19, 2.20 Aug 10, 2026
@hansva

hansva commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

This updates the variable but doesn't save it I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: Hop Conf -sv and -cfv seem broken

2 participants