Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the SCRAM-SHA-256 client processes the server-first message it only checks that the server nonce begins with the client nonce, so a server (or a man in the middle) can echo the client nonce unchanged and the client carries on as though the handshake were sound. RFC 5802 section 5.1 requires the server to append its own nonce to the client's, and accepting an unchanged value drops the server's contribution to the combined nonce and the freshness that comes with it. This tightens the check in ScramScheme to also require the server nonce to be strictly longer than the client nonce, with a regression test; conformant servers always extend the nonce, so interoperability is unaffected.