Repository navigation
fix(vermeer): parse task error_message - #375
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
No unresolved review issues; targeted tests and checks pass.
Review effort: Lite
Findings: None
What changed in this PR
Adds parsing and serialization of Vermeer task error_message values in TaskInfo.
Changes:
- Exposes
error_messagewith an empty-string default. - Includes it in
to_dict(). - Adds coverage for present and missing values.
| File | Description |
|---|---|
vermeer-python-client/src/tests/structure/test_task_data.py |
Tests populated and missing error messages. |
vermeer-python-client/src/pyvermeer/structure/task_data.py |
Adds error-message support to TaskInfo. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
imbajin
approved these changes
Sep 25, 2026
imbajin
left a comment
Member
There was a problem hiding this comment.
Blocking: no. Summary: TaskInfo now preserves the optional Vermeer error_message through parsing and serialization. Evidence: exact-head diff and tests for populated and absent values; latest-head checks passed. Score: 8.7/10.
18 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parse the
error_messagefield returned by the Vermeer task API intoTaskInfo.The field is now exposed through the
error_messageproperty and included into_dict(). Missing fields keep the existing client-style empty-stringdefault.
Tests
error_messageerror_messageCloses #371.