Skip to content

fix(vermeer): parse task error_message - #375

Merged
imbajin merged 1 commit into
apache:mainfrom
PNHD:fix/371-taskinfo-error-message
Sep 25, 2026
Merged

imbajin merged 1 commit into
apache:mainfrom
PNHD:fix/371-taskinfo-error-message

Conversation

@PNHD

@PNHD PNHD commented Sep 25, 2026

Copy link
Copy Markdown
Contributor

Summary

Parse the error_message field returned by the Vermeer task API into
TaskInfo.

The field is now exposed through the error_message property and included in
to_dict(). Missing fields keep the existing client-style empty-string
default.

Tests

  • added coverage for responses with error_message
  • added coverage for responses without error_message
  • targeted Vermeer tests pass
  • targeted Ruff check and format check pass

Closes #371.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

No unresolved review issues; targeted tests and checks pass.

Review effort: Lite
Findings: None

What changed in this PR

Adds parsing and serialization of Vermeer task error_message values in TaskInfo.

Changes:

  • Exposes error_message with an empty-string default.
  • Includes it in to_dict().
  • Adds coverage for present and missing values.
File Description
vermeer-python-client/​src/​tests/​structure/​test_task_data.py Tests populated and missing error messages.
vermeer-python-client/​src/​pyvermeer/​structure/​task_data.py Adds error-message support to TaskInfo.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@imbajin imbajin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking: no. Summary: TaskInfo now preserves the optional Vermeer error_message through parsing and serialization. Evidence: exact-head diff and tests for populated and absent values; latest-head checks passed. Score: 8.7/10.

@imbajin
imbajin merged commit 8aabd41 into apache:main Sep 25, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature vermeer-python-client] TaskInfo does not parse error_message field from task response

3 participants