Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc(config): add schema.sync options #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
doc(config): add schema.sync options #498
Changes from all commits
c70ea8a05437daFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor: These two rows (and CN lines 137-138) give no release for the options. They exist only in apache/hugegraph#3237, which is still open;
git grep schema.syncon apache/hugegraph master finds nothing, and master's<revision>is 1.7.0, the latest release. A 1.7.0 server that readsschema.sync.enabled=trueonly logs "The config option 'schema.sync.enabled' is redundant" (HugeConfig.java:113) and keeps the old behavior. So a reader running 1.7.0 with several HStore servers could take this page to mean schema caches already converge across servers. The same table already marks release-specific content with "For version 1.7.0+" in thebackendrow.Requested change: add a short release note to both rows in EN and CN, for example "Available since the release that includes apache/hugegraph#3237" or the concrete version once it is known, and keep this PR unmerged until #3237 lands.
Uh oh!
There was an error while loading. Please reload this page.