Conversation
The server no longer registers server.role_election or the server.role.* options (apache/hugegraph#3244), so drop them from the en and cn config option pages.
bitflicker64
left a comment
bitflicker64
left a comment
There was a problem hiding this comment.
Blocking: no. Summary: The removal matches apache/hugegraph#3244 at 5117958, which deletes server.role_election and all six server.role.* options while keeping server.role, server.node_id and server.node_role, and on master the options are already a no-op after #3082. One Minor: the 1.7.0 release still runs role election, and #3244 is not merged, so deleting the section without a version note leaves 1.7.0 users with no reference. Evidence: git grep for the option names on apache/hugegraph origin/master (2f827d6e8), the 1.7.0 tag and the #3244 head; GraphManager.initNodeRole()/serverStarted() on master and on 1.7.0; git grep of the doc PR head finds no other references outside the 1.7.0 release notes; the only workflow run at aeac699 (Build and deploy site) is action_required, so the site build has not run on this head.
The 1.7.0 release still runs role election when server.role_election is true, so leave a short version note where the removed block was instead of dropping the only reference for 1.7.0 users.
|
@bitflicker64 the version note is in (5ffb6bc), on both en and cn pages. Could a maintainer approve the "Build and deploy site" run? It is waiting on approval for this fork. This should merge after apache/hugegraph#3244. |
This branch has not been deployed
2 participants
Purpose of the PR
apache/hugegraph#3244 removes
server.role_electionand the sixserver.role.*options from the server. The 1.7.0 release still runs role election whenserver.role_election=true; on master the options have had no effect since apache/hugegraph#3082.This deletes the
server.role_electionrow from the rest-server table and the collapsed "Role Election Config Options" block fromdocs/config/config-option.md, and puts a one-line note in its place saying the options apply to 1.7.0 and earlier only. Both the en and cn pages are changed.Please merge this after apache/hugegraph#3244. The change is text only; I did not build the site locally.