Repository navigation
feat(scan): Support split and parallel scans - Part-2a: read Parquet files by task range - #1002
Merged
wgtmac merged 11 commits intoOct 21, 2026
Merged
Conversation
kamcheungting-db
force-pushed
the
feat/file-scan-task-range-reading
branch
3 times, most recently
from
October 14, 2026 22:25
e94e6b1 to
4396b2f
Compare
Contributor
|
lgtm |
kamcheungting-db
force-pushed
the
feat/file-scan-task-range-reading
branch
from
October 16, 2026 22:08
4396b2f to
72a99ef
Compare
shangxinli
reviewed
Oct 17, 2026
wgtmac
reviewed
Oct 19, 2026
FileScanTaskReader previously rejected tasks that read part of a file. It now passes Parquet task ranges to the reader while keeping the full file size available for reading the footer. Use the first column's starting page to assign each row group to a range. This works when optional row-group offsets are missing and ensures that adjacent ranges read every row exactly once. Keep row positions and inherited row IDs relative to the whole file so deletes still remove the correct rows, even when page offsets are out of order. Recheck task bounds when opening a file, skip empty row groups, and reject invalid page offsets and partial tasks for unsupported formats. Add tests for split boundaries, deletes, row lineage, changed file sizes, and files with missing row-group offsets. Validation: all 306 tests in parquet_test and data_test pass. Formatting and whitespace checks pass. pre-commit could not run because it is not installed and PyPI DNS resolution failed during installation.
Co-authored-by: Isaac <no-reply@databricks.com>
Co-authored-by: Isaac <no-reply@databricks.com>
…alled InitReadContext advanced to the next row-group range before the output schema was built. If schema setup failed, a retried Next() skipped the first range. Opening a range no longer consumes it; ConsumeRowGroupRange() does that once the reader is in place. Co-authored-by: Isaac <no-reply@databricks.com>
Java Iceberg reads a split through parquet-java's withRange(), which keeps a row group when its midpoint (first-column start plus half the compressed size) falls in [start, start + length). Use the same rule so C++ and Java readers pick the same row groups for splits that cut through a row group. Co-authored-by: Isaac <no-reply@databricks.com>
Require shared metadata to remain unchanged for a task's lifetime, with tasks rebuilt after metadata changes. Remove the cached row estimate and derive it from DataFile. Limit the row-count sum guarantee to valid, non-overlapping splits covering a file with unchanged metadata. Keep defensive bounds checks for invalidated tasks and distinguish those checks from the supported metadata contract in the regression tests. Validation: 472 tests passed across scan_test, data_test, and parquet_test; 10 tests skipped. pre-commit passed.
wgtmac
force-pushed
the
feat/file-scan-task-range-reading
branch
from
October 21, 2026 02:44
9749fd6 to
e6787c0
Compare
wgtmac
approved these changes
Oct 21, 2026
wgtmac
left a comment
wgtmac
left a comment
Member
There was a problem hiding this comment.
Thanks for working on this @kamcheungting-db! I've rebased to resolve conflicts and rewrite the test to avoid adding resources. Thanks @shangxinli for reviewing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Let
FileScanTaskReaderread a byte range of a Parquet file. #976 added task ranges but rejected them at read time.How it works
Each row group goes to the split that contains its midpoint: the first column's first page plus half the row group's compressed size. This matches Java Iceberg, which reads splits through parquet-java's
withRange()filter. So splits that cover the file read every row exactly once, and C++ and Java pick the same row groups even when a split boundary cuts through a row group.Example: a file with 100-row groups starting at bytes 4, 1000, and 2000, each about 1000 bytes (midpoints near 500, 1500, and 2500):
_posstart=0, length=1000start=1000, length=2000_posand_row_idstay relative to the whole file, so deletes and row lineage still work.Other changes:
file_offsetis missingNotSupportedTesting
Splits return the same rows,
_pos, and_row_idas a whole-file read, with and without deletes. Also covers missing offsets, out-of-order row groups, invalid offsets and sizes, and splits that contain a row group's start but not its midpoint (and the reverse).ctest --test-dir build-clang -R "^(data_test|parquet_test|scan_test)$" --output-on-failureclang-format --dry-run --Werror,git diff --checkThis pull request and its description were written by Isaac.