Repository navigation
chore: upgrade avro to 3a207fa - #1018
Merged
Merged
Conversation
Co-authored-by: Codex <codex@openai.com>
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
0 open findings
What changed in this PR
Updates the vendored Apache Avro C++ dependency pin to a newer upstream main commit to pick up AVRO-4360 fixes (little-endian float/double wire format on big-endian hosts) and related upstream changes.
Changes:
- Bump
avro-cppFetchContentGIT_TAGfrom209a3735...to3a207fa6....
| File | Description |
|---|---|
| cmake_modules/IcebergThirdpartyToolchain.cmake | Updates the pinned Avro C++ commit hash used by CMake FetchContent. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot stopped reviewing on behalf of
manuzhang due to an error
October 14, 2026 16:15
wgtmac
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump the vendored Avro C++ pin from
209a3735ec330679790824da54b7558db55e4e7fto3a207fa6e87c535b95eafca4cf5a6ef524d77df2, the latest upstreammaincommit at the time of the update.This picks up AVRO-4360 (apache/avro#4043), which makes binary float/double encoding and decoding use Avro's little-endian wire format on big-endian hosts. The upstream change includes independent wire-byte regressions for signed zero, finite limits, infinities, NaN payloads, and fragmented streams. The only other commit in the range updates .NET support.
Validation on macOS arm64 with Apple Clang 21:
avro_testandmanifest_testusing the exact new Avro source; Arrow 25.0.0 and cached dependencies, REST/Hive/SQL disabled.avro_testandmanifest_test: both suites passed (251 Avro tests; 210 manifest tests passed, 18 skipped).CodecTestslinked against the freshly built vendored library: 852 test cases and 103,659 assertions passed, including independent float/double wire-byte regressions.pre-commit run --all-filesandgit diff --check: passed.