Repository navigation
refactor(parquet): simplify row position handling in projections - #1020
Merged
wgtmac merged 1 commit intoOct 16, 2026
Merged
Conversation
advancedxy
force-pushed
the
fix/parquet-nested-metadata-projection
branch
from
October 15, 2026 06:32
06571f2 to
ad0f270
Compare
wgtmac
approved these changes
Oct 16, 2026
Member
|
Thanks @advancedxy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a
ProjectNestedArrayoverload for nested fields without a row-position argument, removing repeatednullptrarguments from recursive projection.Use
ICEBERG_PRECHECKat the record-batch and struct projection entries to validate required row positions. Add one regression test covering nested_posand_row_id.Why
Follow-up to the projection review in #1006.
The record-batch check only inspects top-level fields. Metadata fields nested in a struct could therefore reach projection with a null position array. Checking each struct before projection returns an error without adding checks to individual metadata branches.
Testing
parquet_testpassed on the updated main baseline.git diff --checkpassed.Limitations and follow-up
The current Iceberg reader supplies the separate position array only to top-level fields. This is an implementation limitation, not a restriction on schema projection. The planned Arrow C++ Parquet reader integration described in #1006 will expose positions in the reader's record batches.