Repository navigation
fix(avro): key projection cache on Avro node to avoid OOB read - #1022
Merged
Merged
Conversation
The avro-to-projection cache was keyed on projections.data() only. All empty-struct projections share the same (null) data(), so a second empty struct with more Avro fields reused a cached vector sized for the first and read out of bounds. Include the Avro node in the key and reject out-of-range projected field indexes.
gty404
force-pushed
the
fix/avro-projection-cache-key
branch
from
October 15, 2026 09:13
fc62829 to
9fa7751
Compare
shangxinli
reviewed
Oct 15, 2026
shangxinli
approved these changes
Oct 17, 2026
shangxinli
left a comment
shangxinli
left a comment
Contributor
There was a problem hiding this comment.
The new DirectDecoderTest asserts the cache mapping sizes directly, so it no longer depends on the sanitizer leg to catch a regression.
wgtmac
approved these changes
Oct 22, 2026
Member
|
Thanks @gty404 for fixing this and @shangxinli for the quick review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DecodeStructToBuildercached the Avro-field-index to projection-index mapping keyed onprojections.data()only. All empty-struct projections share the same (null)data(), so a second empty struct with more Avro fields reused a cached vector sized for the first one and read out of bounds, which could end in a wild-pointer dispatch viaStructBuilder::field_builder.{projections.data(), avro_node}. The mapping is built and validated before being cached, and a projected field index outside the Avro record's field count returnsInvalidArgument.Test plan
AvroReaderTest.ProjectEmptyStructsOfDifferentWidths: file with two struct columns of 1 and 6 fields, both read back as empty structs through the direct decoderavro_testsuite passes (196 tests)