Repository navigation
Conversation
manuzhang
marked this pull request as ready for review
October 22, 2026 03:03
Reject incompatible geometry/geography CRS and geography edge algorithms during projection. Resolve omitted Parquet CRS to OGC:CRS84 and include the field path in mismatch errors. Co-authored-by: Codex <codex@openai.com>
Extract common CRS normalization, parameter comparison, and mismatch reporting into a helper used by geometry and geography projection. Co-authored-by: Codex <codex@openai.com>
manuzhang
force-pushed
the
codex/validate-geospatial-projection
branch
from
October 22, 2026 04:08
c9278bd to
7ad4108
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parquet projection currently accepts incompatible geometry/geography parameters, such as
geometry(EPSG:3857)read asgeometry(OGC:CRS84). WKB carries neither the CRS nor the geography edge algorithm, so this silently changes the meaning of the values.Validate CRS case-insensitively and require matching geography edge algorithms. Resolve omitted Parquet CRS to
OGC:CRS84and include the column path in mismatch errors. Add coverage for defaults, all five algorithms, independent parameter mismatches, and nested struct/list/map projection with an unselected sibling.Follow-up to #880, as discussed in #880 (comment). Aligns with the validation in apache/iceberg#17578.
Validation: current core CMake build passed; all 34 tests in
parquet_schema_test.ccpassed when compiled and linked directly against installed Arrow/Parquet 24.0.0 and GTest 1.17.0 with-Wall -Wextra -Werror. Both new regression tests fail against the unchanged projection implementation.clang-format --dry-run --Werrorandgit diff --checkpassed. The full bundle build and bundled Arrow 25 integration suite have not been run.