Repository navigation
Add rename_view to REST Catalog - #4081
Merged
Merged
Conversation
rambleraptor
requested review from
Fokko,
geruh and
kevinjqliu
and removed request for
Fokko,
geruh and
kevinjqliu
October 5, 2026 19:15
- Add @OverRide to RestCatalog/SqlCatalog rename_view and restore it on BigQueryMetastoreCatalog.load_namespace_properties - Split identifiers once in RestCatalog.rename_view - Fix "fully classified" typo in the Catalog.rename_view docstring - Add a cross-namespace rename integration test - Drop a stale skip on test_rest_custom_namespace_separator reintroduced by rebase Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
kevinjqliu
force-pushed
the
rename_view
branch
from
October 25, 2026 04:48
3d8dc7d to
da28da3
Compare
Add a "Rename a view" docs section, list the errors rename_view raises in its docstring, assert view-endpoints-supported enables V1_RENAME_VIEW, and cover rename_view in the special-character identifiers integration test. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kevinjqliu
approved these changes
Oct 25, 2026
kevinjqliu
left a comment
kevinjqliu
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
I pushed 2 small fixes:
- reorders function based on existing pattern (9143fa1)
- add docs and integrate rename_view into the rest of the view tests
Would be nice to follow up with CLI improvement for pyiceberg rename to handle views.
Also I think we're missing update and replace view still (V1_UPDATE_VIEW). #3807 implements replace view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
I'm reviving #2149, which was closed for being stale. I addressed the comments on that PR. This is the last thing we need to have complete view support.
Are these changes tested?
Yes. Unit tests in
tests/catalog/test_rest.pyand integration tests intests/integration/test_catalog.py.Are there any user-facing changes?
rename_viewsupport to the Iceberg REST Catalog.cc @ebyhr @kevinjqliu @abnobdoss @jayceslesar @nhuantho, who reviewed #2149
AI Disclosure: Claude double checked the old PR and made sure the comments were all addressed.