Repository navigation
feat(encryption): [8/N] encryption manager - #4149
Open
xanderbailey wants to merge 2 commits into
Open
xanderbailey wants to merge 2 commits into
xanderbailey wants to merge 2 commits into
Conversation
xanderbailey
commented
Oct 24, 2026
|
|
||
| AES_KEY_LENGTHS = (16, 24, 32) | ||
|
|
||
| AAD_PREFIX_LENGTH = 16 |
Contributor
Author
There was a problem hiding this comment.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working towards #3222
Rationale for this change
Have chosen to go with a structure that matches iceberg-rust rather than java's inheritance, I think this will make it easier in the future to move parts of this down to rust if we choose to. I also think it's a little bit more clear than how java does it.
encrypt(output_file)is missing because we don't have a format for the output file yet so this will come later as we continue to build out this feature.Are these changes tested?
Are there any user-facing changes?