Skip to content

REST: Require metadata-location in view responses #4152

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
geruh merged 1 commit into from
Oct 25, 2026
Merged

REST: Require metadata-location in view responses #4152

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyiceberg/catalog/rest/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -361,7 +361,7 @@ class LoadCredentialsResponse(IcebergBaseModel):


class ViewResponse(IcebergBaseModel):
metadata_location: str | None = Field(alias="metadata-location", default=None)
metadata_location: str = Field(..., alias="metadata-location")
metadata: ViewMetadata
config: Properties = Field(default_factory=dict)

Expand Down
14 changes: 14 additions & 0 deletions tests/catalog/test_rest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
from urllib.parse import parse_qs, urlsplit

import pytest
from pydantic import ValidationError
from requests import Request
from requests.adapters import HTTPAdapter
from requests.exceptions import HTTPError
Expand Down Expand Up @@ -1851,6 +1852,19 @@ def test_load_view_200(rest_mock: Mocker, example_view_metadata_rest_json: dict[
assert actual.config == example_view_metadata_rest_json["config"]


def test_load_view_missing_metadata_location(rest_mock: Mocker, example_view_metadata_rest_json: dict[str, Any]) -> None:
response = {k: v for k, v in example_view_metadata_rest_json.items() if k != "metadata-location"}
rest_mock.get(
f"{TEST_URI}v1/namespaces/fokko/views/view",
json=response,
status_code=200,
request_headers=TEST_HEADERS,
)
catalog = RestCatalog("rest", uri=TEST_URI, token=TEST_TOKEN)
with pytest.raises(ValidationError, match="metadata-location"):
catalog.load_view(("fokko", "view"))


def test_load_view_404(rest_mock: Mocker) -> None:
rest_mock.get(
f"{TEST_URI}v1/namespaces/fokko/views/non_existent_view",
Expand Down
Loading