Repository navigation
CLI: Show metadata location in describe view - #4153
Merged
geruh merged 1 commit intoOct 25, 2026
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped, preserve constructor compatibility and JSON output, and have relevant regression coverage with no blocking issues identified.
No open issues 🎉
What changed in this PR
Adds the metadata location to pyiceberg describe view, matching describe table while leaving JSON output unchanged. This builds on the REST metadata-location support from #4088.
Changes:
- Preserves REST metadata locations on
Viewand includes them in equality checks. - Adds a “Metadata location” row to console output.
- Updates REST and CLI regression assertions.
| File | Description |
|---|---|
tests/integration/test_rest_catalog.py |
Verifies created views expose a metadata location. |
tests/cli/test_console.py |
Checks full view output, including metadata location. |
tests/catalog/test_rest.py |
Checks metadata locations for create, load, and register responses. |
pyiceberg/view/__init__.py |
Adds an optional metadata location and compares it in equality. |
pyiceberg/cli/output.py |
Displays the view’s metadata location. |
pyiceberg/catalog/rest/__init__.py |
Passes the REST response’s metadata location to View. |
Review effort: Balanced
rambleraptor
approved these changes
Oct 25, 2026
rambleraptor
left a comment
rambleraptor
left a comment
Collaborator
There was a problem hiding this comment.
This looks great and a super simple fix.
Could you update the docs (cli.md) to mention that the CLI supports views? I didn't see anything on first look.
ebyhr
approved these changes
Oct 25, 2026
kevinjqliu
force-pushed
the
kevinjqliu-cli-describe-view-metadata-location
branch
3 times, most recently
from
October 25, 2026 03:59
367c83d to
45e35b1
Compare
Match describe table text output by including the view's metadata location, and document the view CLI commands. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
kevinjqliu
force-pushed
the
kevinjqliu-cli-describe-view-metadata-location
branch
from
October 25, 2026 04:01
45e35b1 to
fbcd65a
Compare
Contributor
Author
ty, i added it |
geruh
approved these changes
Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Follow-up to #4088, which added
View.metadata_location.pyiceberg describe viewnow shows the view's metadata location, matchingdescribe table. JSON output is unchanged. Also documents the view CLI commands incli.md.Are these changes tested?
Yes,
test_describe_viewnow checks the full text output.uv run pytest tests/cli/ tests/catalog/test_rest.py: 275 passedprek run --from-ref origin/main --to-ref HEAD(ruff, mypy, markdownlint, codespell): passedAre there any user-facing changes?
Yes,
pyiceberg describe viewshows a new "Metadata location" row.