IGNITE-29122 Fix javac and javadoc warnings in the build log

modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/ExpressionFactory.java

@@ -60,7 +60,7 @@ Supplier<List<AccumulatorWrapper<Row>>> accumulatorsFactory(
      *
      * @param left Collations of left row.
      * @param right Collations of right row.
-     * @param allowNulls Matching null fields. Usually, NULL <> NULL in SQL. Except IS DISTINCT / IS NOT DISTINCT.
+     * @param allowNulls Matching null fields. Usually, {@code NULL <> NULL} in SQL. Except IS DISTINCT / IS NOT DISTINCT.
      * @return Rows comparator.
      */
     Comparator<Row> comparator(

modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/exec/exp/IgniteSqlFunctions.java

@@ -311,15 +311,15 @@ public static boolean gtAny(Object a, Object b) {
         return SqlFunctions.gtAny(a, b);
     }
 
-    /** SQL <=. */
+    /** SQL {@code <=}. */
     public static boolean leAny(Object a, Object b) {
         if (Commons.isBinaryComparable(a, b))
             return Commons.compareBinary(a, b) <= 0;
 
         return SqlFunctions.leAny(a, b);
     }
 
-    /** SQL <. */
+    /** SQL {@code <}. */
     public static boolean ltAny(Object a, Object b) {
         if (Commons.isBinaryComparable(a, b))
             return Commons.compareBinary(a, b) < 0;
@@ -335,7 +335,7 @@ public static boolean eqAny(Object a, Object b) {
         return SqlFunctions.eqAny(a, b);
     }
 
-    /** SQL <>. */
+    /** SQL {@code <>}. */
     public static boolean neAny(Object a, Object b) {
         if (Commons.isBinaryComparable(a, b))
             return Commons.compareBinary(a, b) != 0;

modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/prepare/FieldsMetadata.java

@@ -33,7 +33,7 @@ public interface FieldsMetadata {
 
     /**
      * @param typeFactory Type factory.
-     * @return Query field descriptors collection&
+     * @return Query field descriptors collection.
      */
     List<GridQueryFieldMetadata> queryFieldsMetadata(IgniteTypeFactory typeFactory);
 }

modules/calcite/src/main/java/org/apache/ignite/internal/processors/query/calcite/sql/fun/IgniteOwnSqlOperatorTable.java

@@ -126,7 +126,7 @@ public class IgniteOwnSqlOperatorTable extends ReflectiveSqlOperatorTable {
             OperandTypes.SAME_SAME,
             SqlFunctionCategory.SYSTEM);
 
-    /** Bitwise '&' of two values. */
+    /** Bitwise {@code &} of two values. */
     public static final SqlFunction BITAND =
         new SqlFunction(
             "BITAND",

modules/calcite/src/test/java/org/apache/ignite/internal/processors/query/calcite/integration/PartitionPruneTest.java

@@ -436,7 +436,7 @@ private void testSelect(int sz, boolean withIn, String column) {
                     res.stream().map(row -> row.get(0)).sorted().collect(Collectors.toList())
                 );
             },
-            IntStream.of(values).boxed().toArray(Integer[]::new));
+            IntStream.of(values).boxed().toArray());
     }
 
     /** */

modules/commons/src/main/java/org/apache/ignite/internal/thread/context/OperationContext.java

@@ -31,13 +31,13 @@
  * Represents a storage of {@link OperationContextAttribute}s and their corresponding values bound to the JVM thread.
  * The state of {@link OperationContext} is determined by a sequence of {@link Update}s applied to it. Each Update
  * stores the updated or newly added {@link OperationContextAttribute} values and link to the previous Update.
- * <pre>
+ * <pre>{@code
  *         +-----------+   +-----------+
  *         |           |   | A1 -> V2  |
  * null <--| A1 -> V1  |<--|           |
  *         |           |   | A2 -> V3  |
  *         +-----------+   +-----------+
- *</pre>
+ * }</pre>
  * {@link OperationContext} Updates can be undone in the same order they were applied by closing the {@link Scope}
  * associated with each update (see {@link #set(OperationContextAttribute, Object)} and related methods).
  *<p>

modules/commons/src/main/java/org/apache/ignite/internal/util/CommonUtils.java

@@ -1259,7 +1259,7 @@ public static void quiet(boolean err, Object... objs) {
     public static void quietMultipleLines(boolean err, String multiline) {
         assert multiline != null;
 
-        quiet(err, multiline.split(NL));
+        quiet(err, (Object[])multiline.split(NL));
     }
 
     /**

modules/commons/src/main/java/org/apache/ignite/internal/util/typedef/X.java

@@ -92,7 +92,7 @@ public final class X {
         Method causeMtd;
 
         try {
-            causeMtd = Throwable.class.getMethod("getCause", null);
+            causeMtd = Throwable.class.getMethod("getCause");
         }
         catch (Exception ignored) {
             causeMtd = null;
@@ -615,7 +615,7 @@ private static Throwable getCauseUsingMethodName(Throwable throwable, String mtd
         Method mtd = null;
 
         try {
-            mtd = throwable.getClass().getMethod(mtdName, null);
+            mtd = throwable.getClass().getMethod(mtdName);
         }
         catch (NoSuchMethodException | SecurityException ignored) {
             // exception ignored
@@ -694,7 +694,7 @@ public static boolean isNestedThrowable(Throwable throwable) {
         Class<?> cls = throwable.getClass();
         for (String CAUSE_MTD_NAME : CAUSE_MTD_NAMES) {
             try {
-                Method mtd = cls.getMethod(CAUSE_MTD_NAME, null);
+                Method mtd = cls.getMethod(CAUSE_MTD_NAME);
 
                 if (mtd != null && Throwable.class.isAssignableFrom(mtd.getReturnType()))
                     return true;

modules/commons/src/main/java/org/jsr166/ConcurrentLinkedHashMap.java

@@ -140,7 +140,7 @@ public class ConcurrentLinkedHashMap<K, V> extends AbstractMap<K, V> implements
     /**
      * The maximum capacity, used if a higher value is implicitly
      * specified by either of the constructors with arguments.  MUST
-     * be a power of two <= 1<<30 to ensure that entries are indexable
+     * be a power of two {@code <= 1<<30} to ensure that entries are indexable
      * using ints.
      */
     public static final int MAX_CAP_LIMIT = 1 << 30;

modules/control-utility/src/main/java/org/apache/ignite/internal/commandline/CommandHandler.java

@@ -608,7 +608,7 @@ private void printHelp(List<String> rawArgs) {
         logger.info("");
 
         logger.info(INDENT + join(" ",
-            join(" ", UTILITY_NAME, join(" ", new ArgumentParser(logger, registry, null).getCommonOptions())),
+            join(" ", UTILITY_NAME, join(" ", (Object[])new ArgumentParser(logger, registry, null).getCommonOptions())),
             asOptional("command", true), "<command_parameters>"));
         logger.info("");
         logger.info("");
@@ -674,7 +674,7 @@ private void printCacheHelpHeader(IgniteLogger logger) {
         logger.info(INDENT + "The '--cache subcommand' is used to get information about and perform actions" +
             " with caches. The command has the following syntax:");
         logger.info("");
-        logger.info(INDENT + join(" ", UTILITY_NAME, join(" ", new ArgumentParser(logger, null, null).getCommonOptions())) +
+        logger.info(INDENT + join(" ", UTILITY_NAME, join(" ", (Object[])new ArgumentParser(logger, null, null).getCommonOptions())) +
             " --cache [subcommand] <subcommand_parameters>");
         logger.info("");
         logger.info(INDENT + "The subcommands that take [nodeId] as an argument ('list', 'find_garbage', " +

modules/control-utility/src/test/java/org/apache/ignite/util/GridCommandHandlerTest.java

@@ -1756,7 +1756,7 @@ public void testKillHangingRemoteTransactions() throws Exception {
                     if (id != 0)
                         U.awaitQuiet(lockLatch);
 
-                    cache.invoke(0L, new IncrementClosure(), null);
+                    cache.invoke(0L, new IncrementClosure());
 
                     if (id == 0) {
                         lockLatch.countDown();

modules/core/src/main/java/org/apache/ignite/Ignite.java

@@ -753,6 +753,7 @@ public <T> IgniteQueue<T> queue(String name, int cap, @Nullable CollectionConfig
      * @return Collection of {@link DataRegionMetrics} snapshots.
      * @deprecated Check the {@link ReadOnlyMetricRegistry} with "name=io.dataregion.{data_region_name}" instead.
      */
+    @Deprecated
     public Collection<DataRegionMetrics> dataRegionMetrics();
 
     /**

modules/core/src/main/java/org/apache/ignite/IgniteCache.java

@@ -399,6 +399,7 @@ public IgniteFuture<Void> localLoadCacheAsync(@Nullable IgniteBiPredicate<K, V>
      * @deprecated It is recommended to use {@link Ignite#reentrantLock(String, boolean, boolean, boolean)} instead.
      *      This method will be removed in future releases.
      */
+    @Deprecated
     public Lock lockAll(Collection<? extends K> keys);
 
     /**

modules/core/src/main/java/org/apache/ignite/IgniteSystemProperties.java

@@ -1212,6 +1212,7 @@ public final class IgniteSystemProperties extends IgniteCommonsSystemProperties
      *
      * @deprecated Use {@link DataStorageConfiguration#setMinWalArchiveSize}.
      */
+    @Deprecated
     @SystemProperty(value = "Property for setup percentage of WAL archive size to calculate threshold since which " +
         "removing of old archive should be started", type = Double.class)
     public static final String IGNITE_THRESHOLD_WAL_ARCHIVE_SIZE_PERCENTAGE =

modules/core/src/main/java/org/apache/ignite/configuration/IgniteConfiguration.java

@@ -2444,6 +2444,7 @@ public IgniteConfiguration setTracingSpi(TracingSpi tracingSpi) {
      * @deprecated The Ignite Tracing is deprecated and subject to removal in a future release. Ignite Tracing has been
      * retired in favor of Ignite Performance Statistics and Ignite Metrics.
      */
+    @Deprecated(forRemoval = true)
     public TracingSpi getTracingSpi() {
         return NoopTracingSpi.INSTANCE;
     }

modules/core/src/main/java/org/apache/ignite/configuration/TransactionConfiguration.java

@@ -59,6 +59,7 @@ public class TransactionConfiguration implements Serializable {
       * Default size of pessimistic transactions log.
       * @deprecated Pessimistic tx log linger property has no effect.
       */
+    @Deprecated
     public static final int DFLT_PESSIMISTIC_TX_LOG_LINGER = 10_000;
 
     /** Default transaction serializable flag. */

modules/core/src/main/java/org/apache/ignite/internal/cache/query/index/sorted/inline/InlineObjectBytesDetector.java

@@ -167,7 +167,7 @@ public boolean inlineObjectSupported() {
 
     /**
      * Static analyze inline_size and inline columns set.
-     * e.g.: indexed: (long, obj) and inline_size < 12.
+     * e.g.: indexed: (long, obj) and {@code inline_size < 12}.
      * In this case there is no space for inline object.
      *
      * @param keyDefs Index key definition.

modules/core/src/main/java/org/apache/ignite/internal/cache/query/index/sorted/inline/types/DateValueUtils.java

@@ -31,7 +31,7 @@
 /**
  * DateValue is a representation of a date in bit form:
  *
- * dv = (year << SHIFT_YEAR) | (month << SHIFT_MONTH) | day.
+ * {@code dv = (year << SHIFT_YEAR) | (month << SHIFT_MONTH) | day}.
  */
 public class DateValueUtils {
     /** Calendar with UTC time zone instance. */

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheProxy.java

@@ -63,7 +63,7 @@ public interface IgniteCacheProxy<K, V> extends IgniteCache<K, V>, Externalizabl
      * <p> For example, if you use {@link Integer} as a key and {@code Value} class as a value (which will be
      * stored in binary format), you should acquire following projection to avoid deserialization:
      * <pre>
-     * IgniteInternalCache<Integer, GridBinaryObject> prj = cache.keepBinary();
+     * IgniteInternalCache&lt;Integer, GridBinaryObject&gt; prj = cache.keepBinary();
      *
      * // Value is not deserialized and returned in binary format.
      * GridBinaryObject po = prj.get(1);

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteCacheProxyImpl.java

@@ -1984,7 +1984,7 @@ else if (clazz.isAssignableFrom(IgniteEx.class)) {
      * <p> For example, if you use {@link Integer} as a key and {@code Value} class as a value (which will be
      * stored in binary format), you should acquire following projection to avoid deserialization:
      * <pre>
-     * IgniteInternalCache<Integer, GridBinaryObject> prj = cache.keepBinary();
+     * IgniteInternalCache&lt;Integer, GridBinaryObject&gt; prj = cache.keepBinary();
      *
      * // Value is not deserialized and returned in binary format.
      * GridBinaryObject po = prj.get(1);

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/IgniteInternalCache.java

@@ -180,7 +180,7 @@
  * that class definitions are present in the classpath). By default, cache works with deserialized form
  * (example shows the case when {@link Integer} is used as a key for a binary object):
  * <pre>
- * IgniteInternalCache<Integer, Value> prj = Ignition.grid().cache(null);
+ * IgniteInternalCache&lt;Integer, Value&gt; prj = Ignition.grid().cache(null);
  *
  * // Value will be serialized and stored in cache in binary format.
  * prj.put(1, new Value());
@@ -193,7 +193,7 @@
  * needed for performance reasons. To work with binary format directly you should create special projection
  * using {@link #keepBinary()} method:
  * <pre>
- * IgniteInternalCache<Integer, GridBinaryObject> prj = Ignition.grid().cache(null).keepBinary();
+ * IgniteInternalCache&lt;Integer, GridBinaryObject&gt; prj = Ignition.grid().cache(null).keepBinary();
  *
  * // Value is not deserialized and returned in binary format.
  * GridBinaryObject po = prj.get(1);
@@ -258,7 +258,7 @@ public interface IgniteInternalCache<K, V> extends Iterable<Cache.Entry<K, V>> {
      * (which will be stored in binary format), you should acquire following projection
      * to avoid deserialization:
      * <pre>
-     * IgniteInternalCache<Integer, GridBinaryObject> prj = cache.keepBinary();
+     * IgniteInternalCache&lt;Integer, GridBinaryObject&gt; prj = cache.keepBinary();
      *
      * // Value is not deserialized and returned in binary format.
      * GridBinaryObject po = prj.get(1);

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/PartitionUpdateCounter.java

@@ -98,7 +98,7 @@ public interface PartitionUpdateCounter extends Iterable<long[]> {
     /**
      * Applies counter update out of range. Update ranges must not intersect.
      *
-     * @param start Start (<= lwm).
+     * @param start Start ({@code <= lwm}).
      * @param delta Delta.
      * @return {@code True} if update was actually applied.
      */

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/package-info.java

@@ -16,7 +16,7 @@
  */
 
 /**
- * This package contain cache-related processors & persistence implementation. <br>
+ * This package contain cache-related processors and persistence implementation. <br>
  * See also <a href="
  * https://github.com/apache/ignite/tree/master/modules/core/src/main/java/org/apache/ignite/internal/processors/cache">
  * GitHub Package Readme</a>

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/StorageException.java

@@ -23,7 +23,7 @@
 import org.jetbrains.annotations.NotNull;
 
 /**
- * Exception is needed to distinguish WAL manager & page store critical I/O errors.
+ * Exception is needed to distinguish WAL manager and page store critical I/O errors.
  */
 public class StorageException extends IgniteCheckedException implements InvalidEnvironmentException {
     /** */

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/query/CacheQuery.java

@@ -231,7 +231,8 @@
  *     new org.locationtech.jts.geom.Coordinate(0, 0)
  * });
  *
- * Map.Entry<String, UserData> records = cache.queries().createSqlQuery(MapPoint.class, "select * from MapPoint where location && ?")
+ * Map.Entry&lt;String, UserData&gt; records = cache.queries()
+ *     .createSqlQuery(MapPoint.class, "select * from MapPoint where location &amp;&amp; ?")
  *     .queryArguments(square)
  *     .execute()
  *     .get();

modules/core/src/main/java/org/apache/ignite/internal/processors/odbc/jdbc/JdbcBulkLoadProcessor.java

@@ -33,7 +33,7 @@
  * Unlike other "single shot" request-reply commands, the
  * COPY command the client-server interaction looks like this:
  *
- * <pre>
+ * <pre>{@code
  * Thin JDBC client                            Server
  *        |                                       |
  *        |------- JdbcQueryExecuteRequest ------>|
@@ -66,7 +66,7 @@
  *        |                                       |
  * (close the file)                               |
  *        |                                       |
- * </pre>
+ * }</pre>
  *
  * In case of input file reading error, a flag is carried to the server:
  * {@link JdbcBulkLoadBatchRequest#CMD_FINISHED_ERROR} and the processing

modules/core/src/main/java/org/apache/ignite/internal/processors/query/running/HeavyQueriesTracker.java

@@ -204,7 +204,7 @@ public int getTimeoutMultiplier() {
      * - timeout * multiplier;
      * - timeout * multiplier * multiplier;
      * - etc...
-     * If the multiplier <= 1, the warning message is printed once.
+     * If the multiplier {@code <= 1}, the warning message is printed once.
      *
      * @param timeoutMult Long query timeout multiplier.
      */
@@ -237,7 +237,7 @@ public void setResultSetSizeThreshold(long rsSizeThreshold) {
      *  - size of result set > threshold * multiplier;
      *  - size of result set > threshold * multiplier * multiplier;
      *  - etc.
-     * If the multiplier <= 1, the warning message is printed once.
+     * If the multiplier {@code <= 1}, the warning message is printed once.
      * @return Result set size threshold multiplier.
      */
     public int getResultSetSizeThresholdMultiplier() {

modules/core/src/main/java/org/apache/ignite/internal/processors/query/running/SqlQueryMXBean.java

@@ -63,7 +63,7 @@ void setLongQueryWarningTimeout(
      *      - timeout * multiplier;
      *      - timeout * multiplier * multiplier;
      *      - etc.
-     * If the multiplier <= 1, the warning message is printed once.
+     * If the multiplier {@code <= 1}, the warning message is printed once.
      *
      * @param longQueryTimeoutMultiplier Long query timeout multiplier.
      */
@@ -102,7 +102,7 @@ void setLongQueryWarningTimeout(
      *  - size of result set > threshold * multiplier;
      *  - size of result set > threshold * multiplier * multiplier;
      *  - etc.
-     * If the multiplier <= 1, the warning message is printed once during query execution and the next one on the query end.
+     * If the multiplier {@code <= 1}, the warning message is printed once during query execution and the next one on the query end.
      *
      * @return Result set size threshold multiplier.
      */

modules/core/src/main/java/org/apache/ignite/internal/processors/query/stat/StatisticsProcessor.java

@@ -84,7 +84,7 @@ public StatisticsProcessor(
      * 2) If byObsolescence and no table awailable - clean obsolescence and partition statistics for the given key.
      * 3) Submit tasks for each specified partition.
      * 4) after last task finish gathering - it starts aggregation.
-     * 5) read all partitions & obsolescence from repo and
+     * 5) read all partitions and obsolescence from repo and
      * if byObsolescence = {@code true} - remove unnecessary one and aggregate by specified list
      * if byObsolescence = {@code false} - aggregate all presented in store (because it should contains only actual ones)
      * 5) save aggregated local statistics

modules/core/src/main/java/org/apache/ignite/internal/processors/query/stat/hll/serialization/SerializationUtil.java

@@ -173,7 +173,7 @@ public static byte packVersionByte(final int schemaVersion, final int typeOrdina
      *             If 'auto' is chosen, this value should be <code>63</code>.
      *           </li>
      *           <li>
-     *             If a cutoff of 2<sup>n</sup> is desired, for <code>0 <= n < 31</code>,
+     *             If a cutoff of 2<sup>n</sup> is desired, for {@code 0 <= n < 31},
      *             this value should be <code>n + 1</code>.
      *           </li>
      *         </ul>

modules/core/src/main/java/org/apache/ignite/internal/util/GridConcurrentMultiPairQueue.java

@@ -29,9 +29,9 @@
  * Concurrent queue that wraps collection of {@code Pair<K, V[]>}
  * The only garantee {@link #next} provided is sequentially emptify values per key array.
  * i.e. input like: <br>
- * p1 = new Pair<1, [1, 3, 5, 7]> <br>
- * p2 = new Pair<2, [2, 3]> <br>
- * p3 = new Pair<3, [200, 100]> <br>
+ * {@code p1 = new Pair<1, [1, 3, 5, 7]>} <br>
+ * {@code p2 = new Pair<2, [2, 3]>} <br>
+ * {@code p3 = new Pair<3, [200, 100]>} <br>
  * and further sequence of {@code poll} or {@code forEach} calls may produce output like: <br>
  * [3, 200], [3, 100], [1, 1], [1, 3], [1, 5], [1, 7], [2, 2], [2, 3]
  *

modules/core/src/main/java/org/apache/ignite/internal/util/IgniteUtils.java

@@ -2230,7 +2230,7 @@ public static <T> Iterable<T> asIterable(final Enumeration<T> e) {
     }
 
     /**
-     * Copy source file (or folder) to destination file (or folder). Supported source & destination:
+     * Copy source file (or folder) to destination file (or folder). Supported source and destination:
      * <ul>
      * <li>File to File</li>
      * <li>File to Folder</li>