Skip to content

IGNITE-29130 Fix flaky IgniteClientUserThreadPoolSize test of the C++ thin client #13678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NSAmelchev wants to merge 1 commit into
base: master
Choose a base branch
from
Open

IGNITE-29130 Fix flaky IgniteClientUserThreadPoolSize test of the C++ thin client #13678

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 26 additions & 2 deletions modules/platforms/cpp/thin-client-test/src/ignite_client_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,30 @@ class IgniteClientTestSuiteFixture

BOOST_CHECK_EQUAL(GetActiveConnections(), expect);
}
/**
* Get the number of threads once it stops changing: a joined thread is still listed in the process for a while.
*
* @return Number of threads.
*/
static int32_t GetSettledThreadsCount()
{
int32_t cnt = ignite::common::concurrent::GetThreadsCount();

for (int i = 0; i < 25; ++i)
{
boost::this_thread::sleep_for(boost::chrono::milliseconds(200));

int32_t cnt0 = ignite::common::concurrent::GetThreadsCount();

if (cnt0 == cnt)
break;

cnt = cnt0;
}

return cnt;
}

/**
* Check that client started with specified size of user thread pool started exactly the specified number of threads
* in thread pool.
Expand All @@ -85,7 +109,7 @@ class IgniteClientTestSuiteFixture
server.PushHandshakeResponse(true);
server.Start();

int32_t threadsBefore = ignite::common::concurrent::GetThreadsCount();
int32_t threadsBefore = GetSettledThreadsCount();
int32_t netThreads = 1;

#ifdef _WIN32
Expand All @@ -103,7 +127,7 @@ class IgniteClientTestSuiteFixture
BOOST_CHECK_EQUAL(threadsExpected, threadsActual);
}

int32_t threadsAfter = ignite::common::concurrent::GetThreadsCount();
int32_t threadsAfter = GetSettledThreadsCount();

BOOST_CHECK_EQUAL(threadsBefore, threadsAfter);
BOOST_CHECK_EQUAL(num, cfg.GetUserThreadPoolSize());
Expand Down
Loading