Repository navigation
IGNITE-29169 Use CopyOnWriteIntMap for rarely updated maps on cache hot paths - #13706
Open
NSAmelchev wants to merge 2 commits into
Open
NSAmelchev wants to merge 2 commits into
NSAmelchev wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several int-keyed maps read on the cache operation path and updated only on cache start/stop
still pay for concurrent writes on every read:
GridDhtLocalPartition.cacheMapsandCacheDataStoreImpl.cacheSizestake a read-write lock on each access,DataRegionMetricsImpl.cacheGrpMetricsis a hand-written copy-on-write map with its own lock,
CacheObjectBinaryProcessorImpl.affKeyFieldsboxes the type ID on each lookup.
They now use
CopyOnWriteIntMap(IGNITE-29099), which is designed for this read-mostly case.GridCacheContext.cacheIdBoxed()is removed as no longer needed,CopyOnWriteIntMap.computeIfAbsentgets a lock-free fast path.