Skip to content

Limit repeated warning logs - #17889

Draft
Caideyipi wants to merge 16 commits into
masterfrom
fix-log-throttling
Draft

Caideyipi wants to merge 16 commits into
masterfrom
fix-log-throttling

Conversation

@Caideyipi

@Caideyipi Caideyipi commented Jun 9, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

  • Throttle repeated warning and error logs in authentication, disk allocation, active loading, WAL management, metrics, and background tasks.
  • Keep initial diagnostics visible, isolate independent failure states, and allow messages again after recovery or the throttle interval.
  • Merge the current master while preserving WAL durability, node status transitions, metric sampling, and reporter shutdown behavior.
  • Add regression coverage for suppression, recovery, and independent logging states.

Validation

  • mvn spotless:apply -P with-integration-tests
  • Clean English build of the affected modules and their complete reactor dependencies, followed by focused unit tests: 151 tests, 0 failures, 0 errors, 4 existing skips requiring manual immutable-directory setup.
  • Supplemental reporter tests use the same verified English source outputs and build configuration.
  • Chinese locale: clean test-source compilation of the same affected reactor dependency closure.
  • The full repository test suite and distribution packaging were not run.

@codecov

codecov Bot commented Jun 11, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 74.30341% with 166 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.35%. Comparing base (65ef92f) to head (29bc6d7).

Files with missing lines Patch % Lines
...etrics/metricsets/net/WindowsNetMetricManager.java 0.00% 33 Missing ⚠️
.../metrics/metricsets/net/LinuxNetMetricManager.java 0.00% 24 Missing ⚠️
...e/manager/subscription/SubscriptionMetaSyncer.java 5.55% 17 Missing ⚠️
...torageengine/load/active/ActiveLoadDirScanner.java 39.28% 17 Missing ⚠️
...db/service/metrics/IoTDBInternalLocalReporter.java 77.77% 14 Missing ⚠️
...b/metrics/reporter/iotdb/IoTDBSessionReporter.java 17.64% 14 Missing ⚠️
.../apache/iotdb/db/auth/ClusterAuthorityFetcher.java 47.82% 12 Missing ⚠️
...trics/metricsets/disk/LinuxDiskMetricsManager.java 71.42% 6 Missing ⚠️
...ava/org/apache/iotdb/db/auth/LoginLockManager.java 91.22% 5 Missing ⚠️
...service/metrics/file/SystemRelatedFileMetrics.java 16.66% 5 Missing ⚠️
... and 7 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #17889      +/-   ##
============================================
+ Coverage     48.29%   48.35%   +0.06%     
- Complexity      625      677      +52     
============================================
  Files          5572     5574       +2     
  Lines        411719   412224     +505     
  Branches      54229    54291      +62     
============================================
+ Hits         198820   199329     +509     
+ Misses       212899   212895       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

# Conflicts:
#	iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/coordinator/runtime/PipeMetaSyncer.java
#	iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/pipe/coordinator/runtime/heartbeat/PipeHeartbeatScheduler.java
#	iotdb-core/datanode/src/test/java/org/apache/iotdb/db/conf/directories/strategy/DirectoryStrategyTest.java
#	iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/disk/strategy/MinFolderOccupiedSpaceFirstStrategy.java
# Conflicts:
#	iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/subscription/SubscriptionMetaSyncer.java
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/protocol/thrift/impl/DataNodeInternalRPCServiceImpl.java
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/service/metrics/IoTDBInternalLocalReporter.java
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/tsfile/generator/TsFileNameGenerator.java
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/WALManager.java
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/dataregion/wal/allocation/AbstractNodeAllocationStrategy.java
#	iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/active/ActiveLoadDirScanner.java
#	iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/disk/FolderManager.java
#	iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/disk/strategy/MinFolderOccupiedSpaceFirstStrategy.java
#	iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/utils/JVMCommonUtils.java
#	iotdb-core/node-commons/src/test/java/org/apache/iotdb/commons/utils/JVMCommonUtilsTest.java
@sonarqubecloud

Copy link
Copy Markdown

@Caideyipi
Caideyipi marked this pull request as draft November 4, 2026 02:08
@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant