Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extend the daily IT coverage for #18623 on top of
feat/pipe-logical-backup-sink.[1,3].SHOW PIPEreportingRUNNINGalone is insufficient for this test barrier.IoTDBPipeLogicalBackupITin a dedicated PR workflow, withScalableSingleNodeModeandHighPerformanceModesources and aScalableSingleNodeModetarget. Upload cluster logs and Failsafe reports on failure.The Table rewrite assertion currently exposes a cross-stream replay ordering limitation. After
DELETE FROM measurements WHERE device='d1' AND time<=4, the source rewrites(time=3, device='d1', reading=300). The source query and the archive both retain that rewrite, but restoring the backup loses it. The single-node diagnostic trace shows:Restore reads each data stream in stream-ID order, so later streams replay the same broad deletion after the rewrite. Other devices, null TAGs, and out-of-range target data survive. The public logical-backup documentation disclaims a global transaction across streams; this test makes the concrete delete/rewrite consequence visible for product-boundary review. The failing assertion is retained as a diagnostic regression in this test PR. It does not test process crashes.
Validation on Windows, JDK 17:
git diff --checkpassed; the IT sources compiled.ScalableSingleNodeModerun: 4 tests, 3 passed, 1 failed on the Table rewrite assertion. Source presence and archived rewrite assertions passed.HighPerformanceModerun: 4 tests, 3 passed, 1 failed on the same missing rewrite. The focused run of the Table case on5d2738bca7calso failed with the same replay trace; source presence and archived rewrite assertions passed.it.testfilter.5d2738bca7ccompleted: https://github.com/apache/iotdb/actions/runs/39959079302. Both source configurations ran 4 tests: 3 passed, 1 failed, 0 errors. Both failures reproduce the same archived rewrite followed by deletions from later streams. Cluster logs and Failsafe reports were uploaded for both configurations.