Skip to content

Localize server, client, and tool diagnostics - #19066

Merged
jt2594838 merged 4 commits into
apache:masterfrom
Caideyipi:codex/localize-core-diagnostics
Nov 2, 2026
Merged

jt2594838 merged 4 commits into
apache:masterfrom
Caideyipi:codex/localize-core-diagnostics

Conversation

@Caideyipi

@Caideyipi Caideyipi commented Oct 30, 2026 •

Copy link
Copy Markdown
Collaborator

Description

Chinese builds still emit English diagnostics when inline templates, helper arguments, and stored message variables bypass the compile-time message classes. Route these messages through paired EN/ZH constants across the server, client libraries, and operational tools.

Coverage includes pipe and subscription, metadata, loading and writing, CLI/import/export help and diagnostics, JDBC/Session, UDF validation and execution, REST, cluster/Region operations, query planning and execution, EXPLAIN/ANALYZE, authentication/audit, metrics, and operational tools. The follow-up adds 1,148 localized diagnostic/display sites and 848 paired message keys across 13 modules.

Preserve the original English wording, format argument order, status codes, exception causes, and machine-facing identifiers. Consolidate assembled messages into complete templates. Recognize both English and Chinese permission failures and procedure timeouts so mixed-locale nodes retain the existing skip/retry behavior. Add regressions for these paths and strong-password diagnostics.

Validation

  • Clean full-reactor package passed for all 50 modules in English before the target-branch sync and in Chinese (with-zh-locale) at c2d0821, before the latest master synchronization. Build caches were disabled; required TsFile dependencies were built from matching source in separate isolated Maven repositories.
  • 33 focused tests across five existing test classes passed in each locale, with no failures, errors, or skips; all test sources compiled in both full-reactor builds.
  • Spotless passed for all 13 affected modules. Static key, placeholder, and reference checks passed for 40 EN/ZH message-class pairs and 11,463 keys after the target-branch sync. English-message equivalence checks also passed.
  • Remote CI is running for this update.
  • Latest master synchronization: merged 999721f without manual conflict resolution, preserved upstream tests and localization changes, and passed Spotless and whitespace checks. Full builds and tests were not repeated for this synchronization.

@Caideyipi
Caideyipi marked this pull request as draft October 30, 2026 10:36
@Caideyipi Caideyipi changed the title Localize pipe, subscription, write, load, and metadata diagnostics Localize server, client, and tool diagnostics Nov 2, 2026
@Caideyipi
Caideyipi marked this pull request as ready for review November 2, 2026 04:03
@jt2594838
jt2594838 merged commit cceb9e7 into apache:master Nov 2, 2026
38 of 39 checks passed
@jt2594838
jt2594838 deleted the codex/localize-core-diagnostics branch November 2, 2026 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants