Repository navigation
Localize server, client, and tool diagnostics - #19066
Merged
jt2594838 merged 4 commits intoNov 2, 2026
Merged
Conversation
Caideyipi
marked this pull request as draft
October 30, 2026 10:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Chinese builds still emit English diagnostics when inline templates, helper arguments, and stored message variables bypass the compile-time message classes. Route these messages through paired EN/ZH constants across the server, client libraries, and operational tools.
Coverage includes pipe and subscription, metadata, loading and writing, CLI/import/export help and diagnostics, JDBC/Session, UDF validation and execution, REST, cluster/Region operations, query planning and execution, EXPLAIN/ANALYZE, authentication/audit, metrics, and operational tools. The follow-up adds 1,148 localized diagnostic/display sites and 848 paired message keys across 13 modules.
Preserve the original English wording, format argument order, status codes, exception causes, and machine-facing identifiers. Consolidate assembled messages into complete templates. Recognize both English and Chinese permission failures and procedure timeouts so mixed-locale nodes retain the existing skip/retry behavior. Add regressions for these paths and strong-password diagnostics.
Validation
packagepassed for all 50 modules in English before the target-branch sync and in Chinese (with-zh-locale) at c2d0821, before the latest master synchronization. Build caches were disabled; required TsFile dependencies were built from matching source in separate isolated Maven repositories.