Skip to content

Allow heartbeat retries while a realtime TsFile is in flight - #19075

Merged
jt2594838 merged 2 commits into
masterfrom
codex/fix-pipe-region-downgrading-retry
Nov 2, 2026
Merged

jt2594838 merged 2 commits into
masterfrom
codex/fix-pipe-region-downgrading-retry

Conversation

@Caideyipi

@Caideyipi Caideyipi commented Nov 2, 2026 •

Copy link
Copy Markdown
Collaborator

When region-level downgrading is active, a realtime TsFile can remain in flight while the sink needs heartbeat events to drive retry progress. The source now supplies ordinary heartbeats during that window while keeping later TsFiles and completion barriers ordered behind the in-flight file.

The regression test covers heartbeat delivery and event ordering. Its setup drains the pending queue before enqueueing a heartbeat after a completion barrier so existing heartbeat coalescing does not invalidate the ordering assertions.

Validation: Spotless and git diff --check passed. PipeRealtimeExtractTest passed locally after a clean reactor build with the build cache disabled: 20 tests, 0 failures, 0 errors, 0 skipped. The full unit-test suite was not rerun.

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.75000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 48.09%. Comparing base (999721f) to head (068f330).
⚠️ Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
...n/realtime/PipeRealtimeDataRegionTsFileSource.java 93.75% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #19075      +/-   ##
============================================
- Coverage     48.11%   48.09%   -0.02%     
- Complexity      621      625       +4     
============================================
  Files          5572     5572              
  Lines        410286   411486    +1200     
  Branches      54129    54170      +41     
============================================
+ Hits         197408   197917     +509     
- Misses       212878   213569     +691     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838
jt2594838 merged commit 88f8532 into master Nov 2, 2026
40 of 42 checks passed
@jt2594838
jt2594838 deleted the codex/fix-pipe-region-downgrading-retry branch November 2, 2026 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants