Repository navigation
Fix active LOAD files stranded when the last worker exits - #19076
Merged
Merged
Conversation
|
Collaborator
Author
|
Initial independent review completed with no actionable findings in the full three-file diff or relevant context.
The independent-review gate passes for the reviewed revision. |
Caideyipi
marked this pull request as ready for review
November 2, 2026 07:34
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19076 +/- ##
============================================
+ Coverage 48.11% 48.13% +0.02%
Complexity 621 621
============================================
Files 5572 5572
Lines 410286 410299 +13
Branches 54129 54130 +1
============================================
+ Hits 197408 197498 +90
+ Misses 212878 212801 -77 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jt2594838
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




A complete file published while the last active LOAD worker is retiring can remain pending until another file is enqueued. The scanner skips files already in the pending queue, leaving no runnable to process them.
Track submitted loader tasks under the executor lifecycle lock, release each task reservation on completion, and recheck the queue before leaving. Completions from a stopped executor cannot restart loading or alter its replacement's task count. No production test hooks are added.
Add focused regressions for the final empty-poll race, shutdown, and concurrent submissions, plus real-scanner integration tests for incomplete file publication, restart with mods, and listening-directory hot reload.
Validation:
ActiveLoadTsFileLoaderTest: 7 passed, no failures, errors, or skips.IoTDBLoadTsFileActiveScanITwithClusterIT: 2 passed, no failures, errors, or skips.Full test suites and Chinese-locale compilation were not run. Draft pending independent review.