Repository navigation
Stabilize query execution concurrency unit tests - #19079
Merged
Merged
Conversation
|
shuwenwei
approved these changes
Nov 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19079 +/- ##
============================================
- Coverage 48.11% 48.11% -0.01%
- Complexity 621 625 +4
============================================
Files 5572 5572
Lines 410286 411488 +1202
Branches 54129 54166 +37
============================================
+ Hits 197408 197980 +572
- Misses 212878 213508 +630 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Some query execution unit tests include cold fixture and mock initialization in whole-test timeouts or rely on fixed sleeps, and worker failures can be hidden by later timeouts.
Scope cancellation deadlines to asynchronous operations, keep notification ordering under explicit latch control, and ensure cleanup continues when an earlier cleanup step fails. Use bounded result waits for priority queues, collect shared-block queue workers in completion order, and replace the fragment cleanup sleep with executor barriers. No production code changes.
Validation: all six modified test classes passed locally. The latest fixes passed 52 tests across two focused reactor runs; the unchanged sixth class retains its earlier passing result. Both runs succeeded across 28 modules and recompiled all DataNode test sources. Spotless and git diff --check passed. Full unit tests, zh-locale compilation, and remote CI were not run. Remote test attempts were blocked before compilation by build-extension dependency resolution.