Skip to content

Stabilize query execution concurrency unit tests - #19079

Merged
jt2594838 merged 3 commits into
masterfrom
codex/stabilize-query-cancellation-ut-20261102
Nov 2, 2026
Merged

jt2594838 merged 3 commits into
masterfrom
codex/stabilize-query-cancellation-ut-20261102

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Some query execution unit tests include cold fixture and mock initialization in whole-test timeouts or rely on fixed sleeps, and worker failures can be hidden by later timeouts.

Scope cancellation deadlines to asynchronous operations, keep notification ordering under explicit latch control, and ensure cleanup continues when an earlier cleanup step fails. Use bounded result waits for priority queues, collect shared-block queue workers in completion order, and replace the fragment cleanup sleep with executor barriers. No production code changes.

Validation: all six modified test classes passed locally. The latest fixes passed 52 tests across two focused reactor runs; the unchanged sixth class retains its earlier passing result. Both runs succeeded across 28 modules and recompiled all DataNode test sources. Spotless and git diff --check passed. Full unit tests, zh-locale compilation, and remote CI were not run. Remote test attempts were blocked before compilation by build-extension dependency resolution.

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 48.11%. Comparing base (999721f) to head (d3d726c).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #19079      +/-   ##
============================================
- Coverage     48.11%   48.11%   -0.01%     
- Complexity      621      625       +4     
============================================
  Files          5572     5572              
  Lines        410286   411488    +1202     
  Branches      54129    54166      +37     
============================================
+ Hits         197408   197980     +572     
- Misses       212878   213508     +630     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jt2594838
jt2594838 merged commit 24fd30e into master Nov 2, 2026
39 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants