Repository navigation
Fix hybrid pipe queue memory admission across data regions - #19080
Merged
Merged
Conversation
jt2594838
approved these changes
Nov 2, 2026
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #19080 +/- ##
============================================
- Coverage 48.12% 48.11% -0.01%
Complexity 625 625
============================================
Files 5572 5572
Lines 411488 411495 +7
Branches 54166 54169 +3
============================================
- Hits 198010 198001 -9
- Misses 213478 213494 +16 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Pipe creation can be rejected as the DataRegion count grows because the admission check charges a full InsertNode queue budget for every Region. Default, hybrid, stream, and log sources use a pipe-wide floating-memory limit and can downgrade to TsFile events, so estimate this queue budget once per Pipe.
Keep the per-Region estimate for forced-log sources. Skip the Tablet queue budget for sources that do not retain InsertNode Tablets: realtime disabled, snapshot/query, non-streaming, and file/batch modes. Add regression coverage for the mode aliases and memory-budget boundaries.
Validation
mvn spotless:apply -P with-integration-tests -pl iotdb-core/datanode.This PR has: