Skip to content

Normalize table DELETE predicate identifiers - #19087

Merged
jt2594838 merged 1 commit into
masterfrom
fix/delete-attribute-tag-npe
Nov 3, 2026
Merged

jt2594838 merged 1 commit into
masterfrom
fix/delete-attribute-tag-npe

Conversation

@Caideyipi

Copy link
Copy Markdown
Collaborator

Summary

Normalize table column identifiers before resolving ATTRIBUTE and TAG filters in DELETE predicates. This prevents mixed-case identifiers such as deviceId from producing unresolved filter symbols and a 301 NullPointerException.

Add regression coverage for ATTRIBUTE comparisons, NULL checks, LIKE, and IN with mixed-case identifiers, and strengthen the too-many-devices rejection test to verify data remains intact before a corrected narrower DELETE.

Validation

  • Confirmed both regression cases fail on the base revision with the 301 NullPointerException.
  • TableSimpleIT: 4 selected deletion tests passed, 0 failures, 0 errors, 0 skipped.
  • TableClusterIT (1 ConfigNode, 3 DataNodes): 4 selected deletion tests passed, 0 failures, 0 errors, 0 skipped.
  • Clean source reactor install for the required modules, Spotless apply, and integration-test selection check passed.

@sonarqubecloud

sonarqubecloud Bot commented Nov 2, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov

codecov Bot commented Nov 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.12%. Comparing base (1b2158f) to head (dfe0bfe).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
...otdb/db/queryengine/plan/analyze/AnalyzeUtils.java 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##             master   #19087   +/-   ##
=========================================
  Coverage     48.12%   48.12%           
  Complexity      625      625           
=========================================
  Files          5572     5572           
  Lines        411488   411555   +67     
  Branches      54166    54193   +27     
=========================================
+ Hits         198010   198047   +37     
- Misses       213478   213508   +30     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Caideyipi
Caideyipi marked this pull request as ready for review November 3, 2026 01:55
@Caideyipi

Copy link
Copy Markdown
Collaborator Author

Initial independent review completed. I reviewed the full two-file diff and the related DELETE parser, schema-name normalization, device-filter resolution, and test lifecycle/assertions. No actionable issues were found, and no code changes, new commits, or pushes were needed.

Reviewed SHA, final local HEAD, and confirmed source-branch/PR head: dfe0bfe736f877a6d9179b431d1fb3a659849b33 (base: 24fd30e1ac6b43a32aaeca2066034b1ae81fbc44). The PR has been marked ready for review.

Validation:

  • git diff --check passed. No build or executable tests were rerun during this review. The existing implementation record for this SHA reports 4 selected tests passed under each of TableSimpleIT and TableClusterIT.
  • GitHub checks currently report 40 successes and 2 failures; CI is not fully green.
  • Simple (17) failed in IoTDBLoadTsFileActiveScanIT.testIncompletePublicationSurvivesScannerRestartAndPreservesMods, timing out while waiting for root.p1scan.incomplete.after. That tree-model LOAD test and its execution path are outside this diff; the failure was not reproduced or repaired in this review.
  • SonarCloud reports java:S3078 in unchanged PipeTaskInfo.java. That separate warning was left unchanged.

@jt2594838
jt2594838 merged commit e6b44b5 into master Nov 3, 2026
40 of 42 checks passed
@jt2594838
jt2594838 deleted the fix/delete-attribute-tag-npe branch November 3, 2026 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants