Repository navigation
Normalize table DELETE predicate identifiers - #19087
Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19087 +/- ##
=========================================
Coverage 48.12% 48.12%
Complexity 625 625
=========================================
Files 5572 5572
Lines 411488 411555 +67
Branches 54166 54193 +27
=========================================
+ Hits 198010 198047 +37
- Misses 213478 213508 +30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Initial independent review completed. I reviewed the full two-file diff and the related DELETE parser, schema-name normalization, device-filter resolution, and test lifecycle/assertions. No actionable issues were found, and no code changes, new commits, or pushes were needed. Reviewed SHA, final local HEAD, and confirmed source-branch/PR head: Validation:
|




Summary
Normalize table column identifiers before resolving ATTRIBUTE and TAG filters in DELETE predicates. This prevents mixed-case identifiers such as
deviceIdfrom producing unresolved filter symbols and a 301 NullPointerException.Add regression coverage for ATTRIBUTE comparisons, NULL checks, LIKE, and IN with mixed-case identifiers, and strengthen the too-many-devices rejection test to verify data remains intact before a corrected narrower DELETE.
Validation
TableSimpleIT: 4 selected deletion tests passed, 0 failures, 0 errors, 0 skipped.TableClusterIT(1 ConfigNode, 3 DataNodes): 4 selected deletion tests passed, 0 failures, 0 errors, 0 skipped.