Repository navigation
[To dev/1.3] Preserve LOAD sources after unrecoverable query fallback - #19090
Merged
Merged
Conversation
* Fix LOAD fallback error reporting and scan-boundary resumption * Fix LOAD fallback checkpoints across chunk groups * Fix LOAD fallback metadata error propagation * Fix LOAD fallback metadata batches (cherry picked from commit 9463d01)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backports #19073 (
9463d011e857ca060c8d1c799f803a54fba9c115) todev/1.3, based oneda8986d15926bf7669e7b51de73405ec65bf7ea.The existing fallback iterator could skip an unreadable query task and finish as a successful LOAD, allowing a partially loaded source to be deleted. This change keeps salvaging readable data, reports unrecoverable failures, and retains failed sources for retry. It also resumes each series from its emitted timestamp across repeated chunk groups and propagates metadata traversal failures.
The backport preserves the 1.3 TsFile APIs and ports the regression scenarios into the existing LOAD test fixture. Corrupt test sources span time partitions to exercise decoding and query fallback despite the 1.3 local-load fast path. Conversion-log assertions check all DataNodes because scheduling can select another node.
Validation
mvn spotless:apply -P with-integration-tests: passed.LoadTreeStatementDataTypeConvertExecutionVisitorTest: 13 tests passed.IoTDBLoadTsFileIT#testDirectoryQueryFallbackRetainsOnlyFailedSources: passed with bothSimpleIT(1C1D) andClusterIT(1C3D), includingon-success=none,on-success=delete, source files and sidecar retention, and repair/retry assertions.IoTDBLoadTsFileIT#testConcurrentQueryFallbackFailureRetainsSourceForRetry: passed with bothSimpleIT(1C1D) andClusterIT(1C3D).Validation used local incremental reactor builds. The complete test suite was not run.