Repository navigation
Conversation
Caideyipi
force-pushed
the
fix/table-ttl-default-propagation
branch
3 times, most recently
from
November 4, 2026 02:49
8b42879 to
4870683
Compare
Caideyipi
force-pushed
the
fix/table-ttl-default-propagation
branch
from
November 4, 2026 02:56
4870683 to
d6a8447
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #19110 +/- ##
============================================
+ Coverage 48.22% 48.32% +0.09%
Complexity 625 625
============================================
Files 5572 5572
Lines 411672 411783 +111
Branches 54225 54255 +30
============================================
+ Hits 198547 198983 +436
+ Misses 213125 212800 -325 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Description
Resetting a table TTL with
ALTER TABLE ... SET PROPERTIES ttl=DEFAULTcan leave DataNodes enforcing an infinite TTL while ConfigNode reports the finite database default. For example, after resetting a table to a one-day database TTL,SHOW TABLESreports one day but queries still return two-day-old rows.Resolve the database default before filtering unchanged properties and constructing the table snapshot sent to DataNodes. Prepare the snapshot on a detached table copy so that checking a property update does not mutate consensus-owned metadata before the persistence plan runs. Unset/infinite defaults and unchanged effective TTLs retain their existing behavior.
Add unit and integration coverage for finite, unset, and infinite defaults, unchanged original metadata, persisted/pre-release snapshot consistency, expired reads, expired-write rejection through every DataNode, explicit table overrides, and resetting back to infinite TTL. Give the existing Pipe metadata synchronization test a one-day database TTL so rows remain valid after DEFAULT is actually enforced.
Validation
TableClusterIT.TableClusterIT(1 ConfigNode / 3 DataNodes) andTableSimpleIT(1 ConfigNode / 1 DataNode). The affected Pipe metadata synchronization test passed inMultiClusterIT2DualTableManualEnhancedwith both clusters inHighPerformanceMode.d6a8447b0872755be8c6c761dc7069b5c6381680; Maven exited successfully and reports confirmed no failures, errors, or skipped tests. Full GitHub CI is still in progress.