Skip to content

[To dev/1.3] Improve fair TsFile parser admission - #19111

Open
Caideyipi wants to merge 2 commits into
dev/1.3from
cp/c515756e-dev13
Open

Caideyipi wants to merge 2 commits into
dev/1.3from
cp/c515756e-dev13

Conversation

@Caideyipi

@Caideyipi Caideyipi commented Nov 4, 2026 •

Copy link
Copy Markdown
Collaborator

Cherry-pick of #19106 (c515756) onto dev/1.3 at c0811e5.

Preserves fair admission across available TsFile parser slots, memory and region limits, notification-driven worker scheduling, periodic admission rechecks, close/cancellation ordering, and rejection-reason metrics. All source regression scenarios and assertions are retained.

Compatibility adaptations use the 1.3 parser container monitor, pattern/collector/Tablet APIs and memory-manager test constructor. The missing reason metric tag is added, and the relocated log message is defined in both locale message classes.

Validation:

  • Spotless passed for both affected modules with the with-integration-tests profile.
  • 33 targeted tests passed, with zero failures, errors or skips, across PipeMemoryManagerTest, PipeProcessorSubtaskWorkerTest, PipeProcessorSubtaskExecutionGuardTest, and PipeResourceMetricsTest. All newly added tests were run locally.
  • The complete DataNode dependency closure (26 reactor modules) passed clean compilation, including test sources, in both English and with-zh-locale. All required IoTDB modules and the matching TsFile dependency were built from source. Optional build-cache extensions were disabled only in isolated verification copies; the submitted source was unchanged.
  • Source-to-backport method comparisons and locale key/placeholder parity passed. The 13 changed Java files matched both verification copies byte-for-byte.

Full-repository English/Chinese reactor compilation remains unverified; the completed compilation and test results cover the DataNode dependency closure.

@sonarqubecloud

sonarqubecloud Bot commented Nov 4, 2026

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
B Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant