Repository navigation
[To dev/1.3] Restore IT observation checks (#18899, #19095) [do not squash] - #19112
Merged
Merged
Conversation
Backport the continuous assertion fix and necessary caller corrections from #18899. Execute fail-fast checks for the requested observation period and adapt regression coverage to the tree-model helper available in 1.3. Preserve the 1.3 user and privilege result formats. Table-only helpers, missing overloads, and independent asynchronous deletion and status polling changes are outside this explicitly scoped backport. Manually adapted partial cherry-pick from #18899. (cherry picked from commit c9c16af)
Replace the Awaitility observation deadline with the source PR's monotonic elapsed-time loop so successful slow queries count toward the requested period. Preserve immediate mismatch failure and port the seven-second query regression to the single tree-model helper available in 1.3. The table-only assertion and overloads are absent in 1.3. The restart-cache testWriteRestartAndDeleteDB scenario is also absent, so its session and flush adjustments have no target counterpart. (cherry picked from commit ca8074d)
Caideyipi
changed the title
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
assertDataAlwaysOnEnvpreviously returned after configuringfailFast, so its query and assertions never ran. Restore checks throughout the requested observation period, correct the dormant callers, and count query execution toward that period so a successful slow query does not fail because of a five-second Awaitility margin.This PR contains two separate backports; please do not squash:
c9c16af42f696eb9fcecf287704c7825d2524e2c: restore continuous assertions, correct schema-only query headers and user/privilege expectations, wait for asynchronous permission propagation, and port the applicable helper regression coverage.ca8074d15c824f2533d357778e40f773d02b5565: use the original monotonic elapsed-time observation loop, retain immediate failure on mismatches, and port the seven-second JDBC-query regression.The target base is
dev/1.3atc0811e54d01c1f4480d10506930c44d06cfb12e6. The adaptations retain its single tree-model helper,UserandPathcolumns, and existing privilege names. The table-only APIs and independent deletion/status-polling changes from #18899 are outside the scoped backport. The restart-cache testtestWriteRestartAndDeleteDBchanged by #19095 does not exist in 1.3, so its flush/session changes have no target counterpart.Validation on JDK 17:
96bf5c0a99308454da66448ec62930ede9481f44) were built from clean source for [Test] Fix dynamic status queries and asynchronous deletion polling #18899. The Stabilize IT observation periods and restart cache checks #19095 verification reused those recorded dependencies with unchanged production sources and the same JDK and build profile, and rebuilt the integration-test module and node templates.ClusterIT, along with four affected Pipe tests underMultiClusterIT(schema-only inclusion, authentication exclusion, authentication inclusion with a path pattern, and historical authentication inclusion).ConditionTimeoutException. All three helper regression tests passed with both backports underClusterIT, including the seven-second query and immediate mismatch handling.The full integration suite was not run. The two existing ignored multi/exclusion-pattern scenarios remain ignored. CI for the updated head is tracked separately.