Skip to content

Guard subscription batch snapshots against concurrent updates - #19116

Open
Caideyipi wants to merge 1 commit into
masterfrom
codex/fix-subscription-poll-hashmap-race
Open

Caideyipi wants to merge 1 commit into
masterfrom
codex/fix-subscription-poll-hashmap-race

Fix concurrent subscription batch snapshots

d392b0b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Nov 4, 2026 in 8m 42s

Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 844 in iotdb-core/node-commons/src/main/i18n/en/org/apache/iotdb/commons/i18n/PipeMessages.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this String concatenation with Text block.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknmoOrMcMxEvgXEqN&open=AaGknmoOrMcMxEvgXEqN&pullRequest=19116

Check warning on line 73 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/converter/LoadTableStatementDataTypeConvertExecutionVisitor.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 125).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknnNWrMcMxEvgXEqe&open=AaGknnNWrMcMxEvgXEqe&pullRequest=19116

Check warning on line 1802 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/conf/IoTDBConfig.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 115).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGkns1zrMcMxEvgXEtC&open=AaGkns1zrMcMxEvgXEtC&pullRequest=19116

Check warning on line 77 in iotdb-core/calc-commons/src/main/java/org/apache/iotdb/calc/transformation/dag/column/unary/scalar/BytesToIntColumnTransformer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 124).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknt-CrMcMxEvgXEuB&open=AaGknt-CrMcMxEvgXEuB&pullRequest=19116

Check warning on line 1181 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 119).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknvS_rMcMxEvgXEuh&open=AaGknvS_rMcMxEvgXEuh&pullRequest=19116

Check warning on line 190 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/persistence/pipe/PipePluginInfo.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 114).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknvqCrMcMxEvgXEu4&open=AaGknvqCrMcMxEvgXEu4&pullRequest=19116

Check warning on line 932 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/ProcedureManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 135).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknvS_rMcMxEvgXEud&open=AaGknvS_rMcMxEvgXEud&pullRequest=19116

Check warning on line 220 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/validate/TsFileValidationTool.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "printf" instead of "String.format".

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGkntLgrMcMxEvgXEte&open=AaGkntLgrMcMxEvgXEte&pullRequest=19116

Check warning on line 84 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/TsFileSketchTool.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "printf" instead of "String.format".

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGkns5PrMcMxEvgXEtG&open=AaGkns5PrMcMxEvgXEtG&pullRequest=19116

Check warning on line 110 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/tools/utils/TsFileStatisticScan.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use "printf" instead of "String.format".

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGkns9zrMcMxEvgXEtR&open=AaGkns9zrMcMxEvgXEtR&pullRequest=19116

Check warning on line 2004 in iotdb-client/subscription/src/main/java/org/apache/iotdb/session/subscription/consumer/base/AbstractSubscriptionConsumer.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 115).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknybIrMcMxEvgXEvw&open=AaGknybIrMcMxEvgXEvw&pullRequest=19116

Check warning on line 226 in iotdb-client/session/src/main/java/org/apache/iotdb/session/Session.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 132).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknze1rMcMxEvgXEwg&open=AaGknze1rMcMxEvgXEwg&pullRequest=19116

Check warning on line 37 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/statement/component/IntoComponent.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 134).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknoktrMcMxEvgXEq5&open=AaGknoktrMcMxEvgXEq5&pullRequest=19116

Check warning on line 288 in iotdb-client/cli/src/main/java/org/apache/iotdb/tool/common/Constants.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 153).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGkny4yrMcMxEvgXEwB&open=AaGkny4yrMcMxEvgXEwB&pullRequest=19116

Check warning on line 215 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/storageengine/load/active/ActiveLoadTsFileLoader.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the "AtomicReference" API for synchronization instead of a "synchronized" block.

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknnI2rMcMxEvgXEqd&open=AaGknnI2rMcMxEvgXEqd&pullRequest=19116

Check warning on line 59 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/sql/ast/AsofJoinOn.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 101).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknoKQrMcMxEvgXEqu&open=AaGknoKQrMcMxEvgXEqu&pullRequest=19116

Check warning on line 2125 in iotdb-core/confignode/src/main/java/org/apache/iotdb/confignode/manager/schema/ClusterSchemaManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 108).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknvMFrMcMxEvgXEuV&open=AaGknvMFrMcMxEvgXEuV&pullRequest=19116

Check warning on line 698 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/pipe/receiver/protocol/iotconsensusv2/IoTConsensusV2Receiver.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 172).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknrw6rMcMxEvgXEsI&open=AaGknrw6rMcMxEvgXEsI&pullRequest=19116

Check warning on line 1685 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusPrefetchingQueue.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 175).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknsNmrMcMxEvgXEsg&open=AaGknsNmrMcMxEvgXEsg&pullRequest=19116

Check warning on line 298 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/analyze/cache/partition/PartitionCache.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 116).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknpL8rMcMxEvgXErH&open=AaGknpL8rMcMxEvgXErH&pullRequest=19116

Check warning on line 189 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/relational/planner/iterative/rule/TransformCorrelatedScalarSubquery.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 103).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknnjfrMcMxEvgXEqk&open=AaGknnjfrMcMxEvgXEqk&pullRequest=19116

Check warning on line 442 in iotdb-core/node-commons/src/main/java/org/apache/iotdb/commons/pipe/sink/client/IoTDBSyncClientManager.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 110).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknlRUrMcMxEvgXEp-&open=AaGknlRUrMcMxEvgXEp-&pullRequest=19116

Check warning on line 1695 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/subscription/broker/consensus/ConsensusPrefetchingQueue.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 186).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknsNmrMcMxEvgXEsh&open=AaGknsNmrMcMxEvgXEsh&pullRequest=19116

Check warning on line 819 in iotdb-core/datanode/src/main/java/org/apache/iotdb/db/queryengine/plan/Coordinator.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this instanceof check and cast with 'instanceof InsertRows insertrows'

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknpZBrMcMxEvgXErO&open=AaGknpZBrMcMxEvgXErO&pullRequest=19116

Check warning on line 309 in iotdb-core/consensus/src/main/java/org/apache/iotdb/consensus/iot/IoTConsensusServerImpl.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Line is longer than 100 characters (found 248).

See more on https://sonarcloud.io/project/issues?id=apache_iotdb&issues=AaGknwtgrMcMxEvgXEvW&open=AaGknwtgrMcMxEvgXEvW&pullRequest=19116