Repository navigation
[KYUUBI #5860][SPARK] Return SQL keywords through GetInfo - #7784
Closed
wayne-x-wang wants to merge 1 commit into
Closed
wayne-x-wang wants to merge 1 commit into
wayne-x-wang wants to merge 1 commit into
Conversation
|
Hello @wayne-x-wang, |
wayne-x-wang
force-pushed
the
kyuubi-5860-spark-sql-keywords
branch
from
October 14, 2026 06:32
fc02d58 to
628bc07
Compare
pan3793
approved these changes
Oct 14, 2026
Member
|
Merge Summary:
Posted by |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Closes #5860.
The Spark SQL engine returns
UnimplementedforCLI_ODBC_KEYWORDS, preventing clients from retrieving Spark SQL keywords through ThriftGetInfoor JDBCDatabaseMetaData.getSQLKeywords().Access Spark's
SQLKeywordUtilsthrough a helper in the Spark SQL package and return its comma-separated keyword list, matching Spark's Thrift server behavior.How was this patch tested?
Added two regression tests in
SessionSuite, covering ThriftGetInfoand JDBC metadata. The JDBC fixture requests protocol V11, as required bygetSQLKeywords(). Both new tests failed withUnimplementedbefore the implementation on Spark 3.5.8.All three tests in
SessionSuitepassed on Java 17 with the following profiles:spark-3.5spark-4.0,scala-2.13spark-4.1,scala-2.13spark-4.2,scala-2.13Reproduction commands:
Also ran
dev/reformat, followed by Spotless and Scalastyle checks (0 errors, 0 warnings in the Spark SQL engine), andgit diff --check:Was this patch assisted by generative AI tooling?
Assisted-by: OpenAI Codex (GPT-6)