Repository navigation
[KYUUBI #6314][SPARK] Preserve lineage for JDBC temporary view inserts - #7791
Open
wayne-x-wang wants to merge 1 commit into
Open
wayne-x-wang wants to merge 1 commit into
wayne-x-wang wants to merge 1 commit into
Conversation
|
Hello @wayne-x-wang, |
Contributor
Author
|
Could a maintainer please re-run the failed jobs? All 77 lineage tests passed. The two failures are in EngineRefWithZookeeperSuite and the ZooKeeper 3.7 integration test, outside this patch’s changes. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are the changes needed?
Inserts into JDBC temporary views resolve to
InsertIntoDataSourceCommandwith no targetcatalogTable. The guardedmapthrows aMatchError, so lineage extraction fails even though the write succeeds.Preserve query column names and source lineage when target catalog metadata is absent, matching the existing
SaveIntoDataSourceCommandbehavior.outputTablesremains empty; this change does not infer a JDBC destination identity. Catalog-backed inserts keep their existing behavior.Fixes #6314.
How was this patch tested?
Added an embedded Derby regression that creates a JDBC temporary view through SQL, executes an insert, reads the stored row through JDBC, and checks the command type, absent
catalogTable, source tables, column mappings, and empty output tables. It checks bothparseandtransformToLineage. Without the fix, two separate JVM runs failed with the sameMatchError. Existing tests cover inserts with target catalog metadata.Spark 3.5.8 / Scala 2.12: all 77 lineage tests passed.
build/mvn -B -ntp test \ -pl extensions/spark/kyuubi-spark-lineage -am \ -Pspark-3.5,spark-provided,flink-provided,hive-provided \ -Dtest=none -DwildcardSuites=org.apache.kyuubi.plugin.lineageSpark 4.2.0 / Scala 2.13: the JDBC temporary-view regression passed.
dev/reformat, Spotless, Scalastyle, andgit diff --checkpassed. The historical Kyuubi 1.8.0 / Spark 3.2.3 combination and MySQL were not tested.Was this patch assisted by generative AI tooling?
Assisted-by: Codex (GPT-6)