Skip to content

fix: name plugin report pages after goals - #1217

Open
efegokdemir wants to merge 2 commits into
apache:masterfrom
efegokdemir:codex/issue-949-goal-report-redirects
Open

efegokdemir wants to merge 2 commits into
apache:masterfrom
efegokdemir:codex/issue-949-goal-report-redirects

Conversation

@efegokdemir

Copy link
Copy Markdown

Summary

Update per-goal plugin report pages to use the {goal}-goal.html naming convention requested in #949 while preserving compatibility for existing links.

Changes

  • Generate goal reports as {goal}-goal.html.
  • Keep {goal}-mojo.html compatibility pages as redirects by default.
  • Add maven.plugin.report.generateLegacyMojoReports to disable compatibility pages when desired.
  • Update report links, documentation, annotations, and integration assertions.

Testing

  • mvn -pl maven-plugin-report-plugin -am -DskipITs -Drat.skip -Dspotless.skip=true verify — passed.
  • Targeted plugin-report integration build generated both *-goal.html pages and legacy redirect pages. Its Groovy verification hook is blocked on this machine by the installed Java 27 runtime (Unsupported class file major version 71).
  • git diff --check — passed.

Notes

Fixes #949

Signed-off-by: Efe Gökdemir <efe@rexcode.co.uk>

@gnodet-bot gnodet-bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One low-severity observation on test coverage consistency:

This review was generated by an AI agent, Hermès on behalf of @gnodet.

assert new File( basedir, 'target/site/noop-mojo.html' ).isFile()
assert new File( basedir, 'target/site/report-mojo.html' ).isFile()
assert new File( basedir, 'target/site/noop-goal.html' ).isFile()
assert new File( basedir, 'target/site/report-goal.html' ).isFile()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Missing redirect assertions (not blocking)

The plugin-report IT now asserts that the legacy -mojo.html redirect files exist and point to the new -goal.html pages (e.g. assert new File(basedir, 'target/site/noop-mojo.html').text.contains('noop-goal.html')). This IT only checks that the new -goal.html files exist but doesn't verify the redirect files are created.

Consider adding similar redirect assertions here for consistency.

@slachiewicz slachiewicz added the bug Something isn't working label Oct 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rename {goalname}-mojo.html to {goalname}-goal.html

3 participants