Repository navigation
[maven-4.0.x] Test JDK 27 instead of 26 - #13439
Merged
Merged
Conversation
slachiewicz
marked this pull request as ready for review
October 12, 2026 12:25
gnodet-bot
approved these changes
Oct 12, 2026
gnodet-bot
left a comment
gnodet-bot
left a comment
There was a problem hiding this comment.
LGTM. The bump from JDK 26 to 27 is correct for the current release cycle, the GHA ternary expression is valid, and all three build steps that invoke Spotless (mvn verify -Papache-release, mvn site -Preporting, ./mvnw install -Prun-its,mimir) are consistently updated with the workaround. The initial-build job uses a fixed JDK 17 and is unaffected. The comments clearly document the exit condition (pending a palantir-java-format release in maven-parent). No issues found.
This review was generated by an AI agent, Hermès on behalf of @gnodet.
JDK 26 is out of support now that 27 is released. Spotless is skipped on the JDK 27 jobs only: palantir-java-format crashes there until palantir/palantir-java-format#1786 is released.
The profile applies to local builds as well as CI, so the -Dspotless.skip arguments leave the workflow. Drop it once maven-parent ships a palantir-java-format that runs on JDK 27 (palantir/palantir-java-format#1786).
The model builder tests in maven-impl build the root POM in sessions without java.version, where a <jdk> activation is an error.
slachiewicz
force-pushed
the
agent/jdk-27-maven-4.0.x
branch
from
October 12, 2026 21:15
8887ed7 to
e6351e6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JDK 26 is out of support now that 27 is released, so the JDK 26 jobs test 27 instead. palantir-java-format crashes on JDK 27 (
NoSuchFieldErrorforJCCompilationUnit.endPositions, palantir/palantir-java-format#1786, not yet released), so ajdk27-skip-spotlessprofile in the root POM setsspotless.skipfor the build, IT and site steps and for local builds on JDK 27; the other JDKs keep checking formatting. Drop the profile once maven-parent ships a fixed palantir-java-format.The profile is activated by
java.specification.version=27, not by<jdk>: the model builder tests (ComplexActivationTest) build their POMs in a session without a root directory, soRootLocatorfinds the checkout's.mvnand loads thispom.xmlas the reactor root, with system properties that lackjava.version. A<jdk>activation is an error there; a property activation stays inactive.Same change as #13438 and #13442 on master.
Verified:
mvn test -pl impl/maven-impl -Dtest=ComplexActivationTest→ 1 error with<jdk>[27,)</jdk>, 0 with the property activation.