Skip to content

Skip Spotless on JDK 27 through a POM profile #13442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
slachiewicz merged 3 commits into from
Oct 12, 2026
Merged

Skip Spotless on JDK 27 through a POM profile #13442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
990e3f4
Skip Spotless in the JDK 27 site build too
slachiewicz Oct 12, 2026
3ac67d9
Skip Spotless on JDK 27 through a POM profile
slachiewicz Oct 12, 2026
0e7539e
Activate the JDK 27 Spotless profile by property, not <jdk>
slachiewicz Oct 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/maven.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,8 +219,7 @@ jobs:

- name: Build with downloaded Maven
shell: bash
# palantir-java-format crashes on JDK 27 (palantir/palantir-java-format#1786); drop the skip once a fixed release is in maven-parent
run: mvn verify -Papache-release -Dgpg.skip=true -e -B -V ${{ matrix.java == '27' && '-Dspotless.skip=true' || '' }}
run: mvn verify -Papache-release -Dgpg.skip=true -e -B -V

- name: Build site with downloaded Maven
shell: bash
Expand Down Expand Up @@ -321,8 +320,7 @@ jobs:

- name: Build Maven and ITs and run them
shell: bash
# palantir-java-format crashes on JDK 27 (palantir/palantir-java-format#1786); drop the skip once a fixed release is in maven-parent
run: mvn install -e -B -V -Prun-its,mimir ${{ matrix.java == '27' && '-Dspotless.skip=true' || '' }}
run: mvn install -e -B -V -Prun-its,mimir

- name: Upload Mimir caches
uses: actions/upload-artifact@043fb46d1a93c77aae656e7c1c64a875d1fc6a0a # v7.0.1
Expand Down
16 changes: 16 additions & 0 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -978,6 +978,22 @@ under the License.
</build>

<profiles>
<profile>
<!-- palantir-java-format crashes on JDK 27 (palantir/palantir-java-format#1786);
drop this profile once maven-parent ships a fixed release.
Activated by property, not <jdk>: the model builder tests build this POM in sessions
without java.version, where a <jdk> activation is an error. -->
<id>jdk27-skip-spotless</id>
<activation>
<property>
Comment thread
slachiewicz marked this conversation as resolved.
<name>java.specification.version</name>
<value>27</value>
</property>
</activation>
<properties>
<spotless.skip>true</spotless.skip>
</properties>
</profile>
<profile>
<id>mockito</id>
<activation>
Expand Down
Loading