Let ProjectsRootNode.getNodes(true) use the real keys - #9589
Open
jtulach wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While writing a unit tests for
ProjectsRootNodeI realized thatProjectsRootNode.getNodes(true)violates the intended behavior. It should always wait for optimal result, but it doesn't not. TheaddNotifyschedulessetKeyscalled into a deferredRPtask.... as suchgetChildren().getNodes(true)may return empty array while they should see the result ofsetKeys.Modifying the code in
getNodes(boolean optimalResult)to update the keys whenoptimalResultis requested. This alignes withProjectsRootNode.getNodesCountwhich was already updating the keys withsetKeyswhen optimal result was requested.Prior to change in
ProjectsRootNode.getNodes(boolean)my new unit tests (also part of this PR) were failing. Now they are reliably passing.