fix(dbt): compatibility with pydantic v1 results and fixing the semantic format of flights.yaml - #327
Open
meiliangdeng wants to merge 3 commits into
Open
fix(dbt): compatibility with pydantic v1 results and fixing the semantic format of flights.yaml#327meiliangdeng wants to merge 3 commits into
meiliangdeng wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run osi-to-msi command using following:
ossie-dbt osi-to-msi -i ../../examples/flights.yaml -o semantic_manifest.json
2 exceptions occurred:
cause: msi_pydantic_shim.py use pydantic v1 format for v1 and v2 in https://github.com/dbt-labs/metricflow/blob/main/msi_pydantic_shim.py, pydantic v1 result don`t include model_dump_json, so it must be use v1
cause: the ontology_mappings field does not meet the standard format in flights.yaml , therefore it is occurred
Related Issues
Checklist
Specification
core-spec/and follow the existing structureOntology
ontology/are consistent with spec changesConverters
converters/is updated to reflect spec or ontology changesValidation
validation/are updated if the spec changedDocumentation
docs/is updated to reflect any user-facing changesCONTRIBUTING.mdis updated if the contribution process changedExamples
examples/are added or updated for any new spec constructs or converter supportTests
pytest/ CI green)Compliance